Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: get_recent_logs should be GET request #683

Open
Dorfieeee opened this issue Sep 8, 2024 · 2 comments
Open

API: get_recent_logs should be GET request #683

Dorfieeee opened this issue Sep 8, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Dorfieeee
Copy link
Collaborator

Dorfieeee commented Sep 8, 2024

Issue:

  • get_recent_logs is POST request

Solution:

  • Make get_recent_logs GET request

Extra request:

  • Add from & to parameters that will return all logs between the given timestamp/datetimes.
  • If no to param provided, return all logs from period.

BONUS:

  • Create websocket that will be pushing the latest logs
@Dorfieeee Dorfieeee added bug Something isn't working enhancement New feature or request labels Sep 8, 2024
@cemathey
Copy link
Collaborator

  • get_recent_logs

This does accept a GET request as well as a POST, I'm partial to leaving it at both despite how it's named because it lets people submit a JSON body for the parameters.

The log stream websocket stuff already supports sending latest logs.

Looking at adding the from/to parameters right now though.

@LordofAgents
Copy link
Collaborator

I am not sure if we should add from/to parameters to it. These already exists in get_historical_logs.
Is there any usecase that would need from/to parameters in get_recent_logs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants