-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 Customize default title for auto-threads #29
Comments
I think you could do all of those variants with variables? Similar to the way default messages have
*count will shorten any text variants to specified length or, if empty, max that discord allows |
While it would be nice for programmers I worry about the general public having to look up the available variables/options and entering free text. Would be nice to get some sort of dropdown list for this imo, even if it limits customization slightly. |
How about this? Types:
|
Good idea |
After having used Needle on my server this feature is definitely something that would beneficial. Particularly as I am using it auto-thread posts made by a bot. In my instance Link Title is definitely the most important option. I'm not sure I see the value in Link URL. First characters is also a good option. Though a more suitable name would be |
push - would love that |
That would be so great! |
This comment was marked as off-topic.
This comment was marked as off-topic.
I very much like this idea! It works well both for customization and simplicity. |
@Snailedlt
This is the plan :)
I don't really like this UX, and Discord wants basically all intreactions to be through commands (not when users write messages, etc) I do have a plan for implementing this. I just need to find the time... |
@MarcusOtter ohh yes! |
Update on this: I added support for RegEx, message variables, and a custom max title length. Will be out with the next update (along with a LOT of other changes). Example of the feature: Oh, and of course we provide options for people that don't want to write RegEx: |
How would this feature respond to the message being an embed? For example I'm thinking of using needle to auto create threads on my sesh.fyi posts. Would it be possible to pull the title value from an embed? @MarcusOtter |
Excellent question @DooNotResuscitate, I had not tested it. Right now it doesn't work! How do you suggest I implement support for this? My initial idea is to just append all embeds (title + description + fields + footer) for every embed. It might look messy but we can't really assume that an embed will always have the most important content in the description or in the fields, I think. |
My personal suggestion would be to just pull the value from the title field - the Apollo bot (which has built-in thread creation) just uses the embed title for the thread title. It also includes the event time, but that's because it knows what date exactly to pull. So for my purposes I would be content with just the embed title being pulled, but I'm wondering how it would be listed as an option like the others above. Maybe a separate parameter would need to be added for embeds specifically? Something like the already existing "title-format" and also "title-format-embed"? That way you could give a couple options specifically for if an embed is detected like: Title, Description, Title + Description, etc. @MarcusOtter |
This is not something I would make configurable, we should just pick a reasonable default to keep the amount of unnecessary options down. Since you will be able to regex on this anyways, I think I'll just do (title + \n\n + description + \n\n + field title + \n + field description + \n\n + footer) and then if you know you only want the title you can just target that with a regex. The message content for the embed you showed would be ("..." for lazyness)
|
Yeah if the returned output can be regexed, then I think your default is just fine. |
So with this implemented, would the plain default with no |
The default would be the first 50 characters of the message, where the message in this case is the message content + embeds content. So if you have more than 50 characters in the message, you will never see the embed part (with the default settings). |
Got it - so in the case of the message being just the embed by itself, would be first 50 chars of the embed. That works, and I assume the regex will parse over the whole entire message so I could pull whatever part out? |
Yep! |
Is your request for improvement related to a problem? Please describe.
From MumbleMarvin#2812 on Discord:
Right now the default title for a thread is
Username (yyyy-MM-dd)
. As Marvin points out, it would be nice if this was customizeable.Describe the solution you'd like
Title options (?):
Perhaps the default can be
Name (yyyy-MM-dd)
but if an image or link exists, override it? Though that has problems if someone links to, say, documentation for some programming thing as a source for their question, you wouldn't want that to override. Needs some thinking about.Solutions:
Option A
When creating a thread, add another optional parameter for the default thread title, where you are given different options.
Something like
/configure autothreading
channel: #general
default-title: First X characters of message
Option B
A new command like
/configure default-title
value: First X characters of message
which would set the default for all auto-threads.Additional context
Leaning towards Option A because it's not an extra command, and it would be configurable on a per-channel basis.
Would like feedback on the different title options!
The text was updated successfully, but these errors were encountered: