Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create generic abstracts and interfaces for repositories and services #15

Open
Marco-Sulla opened this issue Nov 10, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@Marco-Sulla
Copy link
Owner

Even if the code is auto-generated, is cumbersome that the same code is copy-pasted very much time.
I think it's better to implement a AbstractRepository and an Repository interface, that shares the common code to all repositories created with EWA. This abstract and interfacecan be useful also to people that do NOT want to use EWA. The same think should be done also for services.

For this reason, the findByNameOfUniqueId() must be renamed simply findById(). This also improves abstraction and encapsulation. Interface for models and aggregators should also be implemented.

PS: are specific interfaces for repo and services really needed? Evaluate to eliminate them.

@Marco-Sulla Marco-Sulla added the enhancement New feature or request label Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant