Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override accent breaks SIB jump list/taskbar preview corners and colors #289

Closed
7kt4 opened this issue Apr 27, 2024 · 8 comments
Closed
Labels
Processed The issue has been resolved and is awaiting confirmation. question Further information is requested solved in upstream project This issue is already solved in the upstream project, just wait for the porting

Comments

@7kt4
Copy link
Contributor

7kt4 commented Apr 27, 2024

Describe the bug

A clear and concise description of what the bug is:
Override accent breaks SIB jump list/taskbar preview corners and colors

Description ....

To Reproduce
Use 2.2.0 and enable override accent.
The corners are broken and the color used is much darker than the glass color.

Screenshots
How it looks now:
image

How it should look/looked in last version:
image

Additional information (please complete the following information):

OS Version : Windows 10 2021 IoT LTSC
Software Version : 2.2.0

What other third-party software do you use:

windhawk mods

Additional context

@7kt4 7kt4 added the question Further information is requested label Apr 27, 2024
@kfh83
Copy link
Contributor

kfh83 commented Apr 27, 2024

Describe the bug

A clear and concise description of what the bug is:
Override accent breaks SIB jump list/taskbar preview corners and colors

Description ....

To Reproduce Use 2.2.0 and enable override accent. The corners are broken and the color used is much darker than the glass color.

Screenshots How it looks now: image

How it should look/looked in last version: image

Additional information (please complete the following information):

OS Version : Windows 10 2021 IoT LTSC
Software Version : 2.2.0

What other third-party software do you use:

windhawk mods

Additional context

As far as im concerned they have never been overriden and i think they are getting overriden on this new version:

image

If you look closely, you can see a reflection in the preview.

@7kt4
Copy link
Contributor Author

7kt4 commented Apr 27, 2024

yes, they have never been overridden. interesting. i wonder what causes the darker colors

@Maplespe
Copy link
Owner

Maplespe commented Apr 27, 2024

Check the custom color on StartIsBack and set the color to translucent blue (your theme color or DWMBlurGlass color)
As I recall, Accent's color layer is still in effect, and DWMBlurGlass does not override its color layer.

@kfh83
Copy link
Contributor

kfh83 commented Apr 27, 2024

Check the custom color on StartIsBack and set the color to translucent blue (your theme color or DWMBlurGlass color) As I recall, Accent's color layer is still in effect, and DWMBlurGlass does not override its color layer.

image

Even if you do have the correct color theoretically, it does seem to be too dark.

@Maplespe
Copy link
Owner

This seems to be some layer blending issue with AeroBackdrop, other effects (Blur, Acrylic) don't seem to have this issue.

@kfh83
Copy link
Contributor

kfh83 commented Apr 28, 2024

This seems to be some layer blending issue with AeroBackdrop, other effects (Blur, Acrylic) don't seem to have this issue.

What i suspect it might be is that StartIsBack forces its own colorization and its rendering on top of the DWMBlurGlass one, but i have no idea

@7kt4
Copy link
Contributor Author

7kt4 commented May 1, 2024

The DWMBlurGlass seems to be rendering the color twice in the taskbar. Sometimes, when I restart DWM (maybe 10% of the time), a bug occurs where the colors are 2x as dark as they need to be even on the titlebars

image

@kfh83
Copy link
Contributor

kfh83 commented May 1, 2024

The DWMBlurGlass seems to be rendering the color twice in the taskbar. Sometimes, when I restart DWM (maybe 10% of the time), a bug occurs where the colors are 2x as dark as they need to be even on the titlebars

image

What's actually happening on the taskbar is DWMBlurGlass is only applying one layer of colorization (either ColorizationColor (black taskbar) or ColorizationAfterglow (dark taskbar)). You can see the same effect in windows if you turn down 2 of the balances in the GUI. @ALTaleX531 seems to already have found a cause (and maybe a fix).

You can also consistently recreate this bug by injecting DWMBlurGlass after explorer is started or saving a setting, and you can fix by restarting explorer.

@ALTaleX531 ALTaleX531 added the solved in upstream project This issue is already solved in the upstream project, just wait for the porting label Jun 20, 2024
@Maplespe Maplespe added the Processed The issue has been resolved and is awaiting confirmation. label Nov 27, 2024
@Maplespe Maplespe closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Processed The issue has been resolved and is awaiting confirmation. question Further information is requested solved in upstream project This issue is already solved in the upstream project, just wait for the porting
Projects
None yet
Development

No branches or pull requests

4 participants