Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the CONTRIBUTING.md guidelines to order function arguments. #358

Open
SupremoUGH opened this issue Jun 19, 2023 · 1 comment
Open

Change the CONTRIBUTING.md guidelines to order function arguments. #358

SupremoUGH opened this issue Jun 19, 2023 · 1 comment

Comments

@SupremoUGH
Copy link
Contributor

SupremoUGH commented Jun 19, 2023 •
edited
Loading

Makes sense, it should probably be part of the `CONTRIBUTING.md` guidelines. Something like: first owned values, then mutable owned values, then immutable refs, then mutable refs, then closures.

Originally posted by @SupremoUGH in #356 (comment)

Change the guidelines and apply them to the codebase.
@SupremoUGH SupremoUGH mentioned this issue Jun 19, 2023
Merged
4 tasks
@mahmudsudo
Copy link

can i take on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SupremoUGH @mahmudsudo