Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out whether OnTimestampSet = Aura affect us #901

Closed
Dengjianping opened this issue Nov 23, 2022 · 1 comment
Closed

Figure out whether OnTimestampSet = Aura affect us #901

Dengjianping opened this issue Nov 23, 2022 · 1 comment
Labels
A-consensus Area: Issues and PRs related to Consensus

Comments

@Dengjianping
Copy link
Contributor

It happened to cumulus release-v0.9.320.
Related pr: paritytech/cumulus#1877

@Garandor
@Dengjianping Dengjianping added the A-consensus Area: Issues and PRs related to Consensus label Nov 23, 2022
@Garandor
Copy link
Contributor

Garandor commented Nov 30, 2022 •
edited
Loading

I suppose a description in that linked PR would've been helpful, but anyways,

It's used for a sanity check by Aura in https://github.com/paritytech/substrate/blob/polkadot-v0.9.26/frame/aura/src/lib.rs#L299

Closing as WONTFIX as it does not affect us:

  1. We no longer use Aura slots
  2. Nimbus slots are defined by RelaychainBlockNumberProvider instead of cumulus_pallet_parachain_system::pallet_timestamp so they don't depend on RTC time

Thanks for raising this @Dengjianping

@Garandor Garandor closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Issues and PRs related to Consensus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dengjianping @Garandor