Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TX-pause updates & Maintenance Mode #769

Open
3 of 4 tasks
ghzlatarev opened this issue Aug 22, 2022 · 3 comments · Fixed by #771
Open
3 of 4 tasks

TX-pause updates & Maintenance Mode #769

ghzlatarev opened this issue Aug 22, 2022 · 3 comments · Fixed by #771
Assignees
@Dengjianping
Labels
A-runtime Area: Issues and PRs related to Runtimes A-security Area: Issues and PRs related to Security P-unreleased Product: yet to be released product related features
Milestone
v4.0.1

Comments

@ghzlatarev
Copy link
Contributor

ghzlatarev commented Aug 22, 2022 •
edited by Garandor
Loading

Some improvements that will make our life easier if we need to respond to a hack:
@ghzlatarev ghzlatarev added the A-runtime Area: Issues and PRs related to Runtimes label Aug 22, 2022
@ghzlatarev ghzlatarev added this to the v3.4.0 milestone Aug 22, 2022
@ghzlatarev ghzlatarev self-assigned this Aug 22, 2022
@ghzlatarev ghzlatarev mentioned this issue Aug 24, 2022
Merged
4 tasks
@Dengjianping
Copy link
Contributor

Just FYI: paritytech/substrate#12092

@Dengjianping
Copy link
Contributor

Perhaps System and the pallet itself should not be paused as well.

@ghzlatarev
Copy link
Contributor Author

ghzlatarev commented Aug 29, 2022 •
edited
Loading

Perhaps System and the pallet itself should not be paused as well.

Actually this is already handled in the BaseCallFilter https://github.com/Manta-Network/Manta/blob/manta/runtime/calamari/src/lib.rs#L186-L194 but I just realized we can jut handle the unapausable pallets there, so maybe no need to make it configurable in the pallet.

@Garandor Garandor modified the milestones: v3.4.0, v3.5.0 Sep 9, 2022
@ghzlatarev ghzlatarev changed the title TX-pause updates TX-pause updates & Maintenance Mode Oct 11, 2022
@ghzlatarev ghzlatarev assigned zqhxuyuan and unassigned ghzlatarev Oct 11, 2022
@ghzlatarev ghzlatarev modified the milestones: v4.0.0, v4.0.1 Dec 9, 2022
@Garandor Garandor reopened this Dec 19, 2022
@ghzlatarev ghzlatarev assigned ghzlatarev and unassigned zqhxuyuan Feb 8, 2023
@ghzlatarev ghzlatarev added P-unreleased Product: yet to be released product related features A-security Area: Issues and PRs related to Security labels Jun 27, 2023
@Garandor Garandor assigned Garandor and unassigned ghzlatarev and Garandor Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dengjianping Dengjianping

Labels
A-runtime Area: Issues and PRs related to Runtimes A-security Area: Issues and PRs related to Security P-unreleased Product: yet to be released product related features
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging a pull request may close this issue.

Update tx-pause pallet to make it easier to pause stuff Manta-Network/Manta
4 participants
@zqhxuyuan @Dengjianping @Garandor @ghzlatarev