Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of specified font name #3413

Closed
behackl opened this issue Oct 22, 2023 · 2 comments
Closed

Improve handling of specified font name #3413

behackl opened this issue Oct 22, 2023 · 2 comments
Labels
good first issue Good for newcomers new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)

Comments

@behackl
Copy link
Member

behackl commented Oct 22, 2023

Currently our documentation build throws several warnings like

[10/22/23 18:12:47] WARNING  Font monospace not in [...]
[10/22/23 18:14:58] WARNING  Font sans not in [...]
[10/22/23 18:15:00] WARNING  Font sans-serif not in [...]

See https://readthedocs.org/api/v2/build/22307289.txt for the complete log of a recent build.

There are two issues here:

  • The font sans-serif should probably also be referred to as sans.
  • Miscapitalized fonts are currently not registered correctly: in the examples above, Monospace and Sans are actually included by the list returned by manimpango.list_fonts(). I think it would be a good idea to automatically correct this user input error: if the specified font is not included in the list, manim should check whether the capitalized version is there -- and if so, use that value instead.
@behackl behackl added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Oct 22, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Dev Board Oct 22, 2023
@behackl behackl added the good first issue Good for newcomers label Oct 24, 2023
@staghado
Copy link
Contributor

Can I take a stab at this?

@behackl
Copy link
Member Author

behackl commented Oct 30, 2023

Can I take a stab at this?

Sure, much appreciated! Feel free to ask questions here or in the development-chat in our Discord -- but otherwise just submit a PR with your proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants