Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changes to immutable labels prevent migrations to newer chart versions #318

Closed
dgerhardt opened this issue Oct 31, 2023 · 5 comments
Closed
Labels
bug Something isn't working Stale

Comments

@dgerhardt
Copy link

dgerhardt commented Oct 31, 2023

Describe the bug
The chart's template for the clamav StatefulSet currently sets common labels for volumeClaimTemplates. This is a problem because the labels are immutable and the template sets a value with the chart's version. As a consequence, updates to newer versions of the chart will fail.

Environment

  • Kubernetes 1.27
  • Helm 3.12
  • Mailu chart 1.5.0 (updating from 1.4.0)

Additional context
This seems to be a common pitfall for Helm charts: helm/charts#7803

Manifest excerpt:

apiVersion: apps/v1
kind: StatefulSet
metadata:
  labels:
    # This is fine:
    helm.sh/chart: mailu-1.4.0
  name: mailu-clamav
spec:
  volumeClaimTemplates:
  - apiVersion: v1
    kind: PersistentVolumeClaim
    metadata:
      labels:
        # This causes problems during updates (immutable):
        helm.sh/chart: mailu-1.4.0
@dgerhardt dgerhardt added the bug Something isn't working label Oct 31, 2023
@dominch
Copy link

dominch commented Nov 17, 2023

same thing failed on my side :/
temporary workaround is to remove clamav StatefulSet before upgrade (so it's recreated)

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@dgerhardt
Copy link
Author

Still relevant.

@github-actions github-actions bot removed the Stale label Dec 20, 2023
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 19, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

2 participants