-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade alpine #1851
Upgrade alpine #1851
Conversation
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryBuild failed: |
I agree that removing cyrus-sasl-plain is the easiest approach for now. If people really want the functionality back, we could look into building cyrus-sasl-plain manually. bors try |
bors try |
tryBuild failed: |
New error for building admin image.
|
This is a defect which is reported at alpine: They plan to include a fix in 3.14.1 which is scheduled in 8 days (according to the milestone) We could wait until 3.14.1 is released. Or perhaps it is possible to use an older version of the package? |
Let's wait; I'll revisit it in a week or so |
New release date A temporary workaround is probably using |
IMHO ARM images should be build using the same base image as the rest... unless there is a good reason for them to be different. We will use 3.14.1 when it's available |
The alpine 3.14.1 milestone has been violated again. It appears to show that no work has happened at all. All issues still have the same status. It might take months before the next alpine version is released. As a workaround we could try using openssl instead of libressl. |
bors try |
tryBuild failed: |
bors try |
Thanks for submitting this pull request. bors try Note: if this build fails, read this. |
tryAlready running a review |
tryBuild failed: |
bors try |
tryBuild succeeded: |
I'm testing with
Build successful locally The download / PIP3 upgrade takes a lot of time in total, even when using an optimized cached build. Is there a good reason to upgrade PIP every time, even when using a recent Python image? |
No. Since this PR is meant to be backported I went for the least intrusive changes I could... but there is no reason for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
bors r+ |
Build succeeded: |
@Mergifyio backport 1.8 |
Command
|
1908: Optimize docs/Dockerfile r=mergify[bot] a=Erriez - Convert .rst to .html in temporary `python:3.8-alpine3.14` build image - Remove all unused packages - Use `nginx:1.21-alpine` deployment image ## What type of PR? Optimize/fix `docs/Dockerfile` ## What does this PR do? ### Related issue(s) - Mention an issue like: #1851 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. ## Testing The following tests has been executed locally: ```bash export DOCKER_ORG=user export DOCKER_PREFIX= export MAILU_VERSION=master cd tests time docker-compose -f build.yml build --no-cache docs real 0m18.850s user 0m0.317s sys 0m0.124s docker images REPOSITORY TAG IMAGE ID CREATED SIZE user/docs master 3de6c8612cf3 19 seconds ago 38.1MB docker run -it --rm --name mailu-docs -p 80:80 user/docs:master Open web browser: Clear caches http://localhost:80/master ``` Co-authored-by: Erriez <Erriez@users.noreply.github.com>
What type of PR?
bug-fix
What does this PR do?
Upgrade all the images to alpine 3.14 and switch from libressl to openssl on the admin container to work around a bug in alpine
Related issue(s)
Prerequistes
Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.