Upgrade alpine #1851

nextgens · 2021-07-05T13:55:25Z

What type of PR?

bug-fix

What does this PR do?

Upgrade all the images to alpine 3.14 and switch from libressl to openssl on the admin container to work around a bug in alpine

Related issue(s)

Prerequistes

Before we can consider review and merge, please make sure the following list is done and checked.
If an entry in not applicable, you can check it or remove it from the list.

In case of feature or enhancement: documentation updated accordingly
Unless it's docs or a minor change: add changelog entry file.

mergify · 2021-07-05T13:55:58Z

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors · 2021-07-05T14:38:56Z

try

Build failed:

CI-Done

Diman0 · 2021-07-05T15:17:05Z

I agree that removing cyrus-sasl-plain is the easiest approach for now. If people really want the functionality back, we could look into building cyrus-sasl-plain manually.

bors try

Diman0 · 2021-07-05T16:28:32Z

bors try

bors · 2021-07-05T16:33:27Z

try

Build failed:

CI-Done

Diman0 · 2021-07-05T16:41:35Z

New error for building admin image.

 (1/10) Installing curl (7.77.0-r1)
(2/10) Installing libressl3.3-libcrypto (3.3.3-r0)
(3/10) Installing libressl3.3-libssl (3.3.3-r0)
(4/10) Installing libressl3.3-libtls (3.3.3-r0)
ERROR: libressl3.3-libtls-3.3.3-r0: trying to overwrite usr/lib/libtls.so.20 owned by libretls-3.3.3-r0.
ERROR: libressl3.3-libtls-3.3.3-r0: trying to overwrite usr/lib/libtls.so.20.0.3 owned by libretls-3.3.3-r0.
(5/10) Installing libressl (3.3.3-r0)

Diman0 · 2021-07-05T16:54:36Z

This is a defect which is reported at alpine:
https://gitlab.alpinelinux.org/alpine/aports/-/issues/12763#note_163217

They plan to include a fix in 3.14.1 which is scheduled in 8 days (according to the milestone)
https://gitlab.alpinelinux.org/alpine/aports/-/milestones/178

We could wait until 3.14.1 is released. Or perhaps it is possible to use an older version of the package?

nextgens · 2021-07-05T18:40:07Z

Let's wait; I'll revisit it in a week or so

Erriez · 2021-07-24T10:53:08Z

New release date Alpine 3.14.1 is planned for Aug 1, 2021.

A temporary workaround is probably using Alpine 3.13 to build ARM images.

nextgens · 2021-07-24T12:54:07Z

build ARM images.

IMHO ARM images should be build using the same base image as the rest... unless there is a good reason for them to be different.

We will use 3.14.1 when it's available

Diman0 · 2021-08-03T08:35:51Z

The alpine 3.14.1 milestone has been violated again. It appears to show that no work has happened at all. All issues still have the same status. It might take months before the next alpine version is released.

As a workaround we could try using openssl instead of libressl.

nextgens · 2021-08-03T11:48:16Z

bors try

bors · 2021-08-03T11:58:30Z

try

Build failed:

CI-Done

nextgens · 2021-08-03T12:02:13Z

bors try

mergify · 2021-08-03T12:04:57Z

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors · 2021-08-03T12:04:58Z

try

Already running a review

bors · 2021-08-03T12:12:02Z

try

Build failed:

CI-Done

nextgens · 2021-08-03T12:31:01Z

bors try

bors · 2021-08-03T12:55:29Z

try

Build succeeded:

CI-Done

Erriez · 2021-08-03T16:30:31Z

The alpine 3.14.1 milestone has been violated again. It appears to show that no work has happened at all. All issues still have the same status. It might take months before the next alpine version is released.

I'm testing with python:3.8-alpine3.14 locally for almost all images. Reason is that Python and PIP are already installed on alpine which saves Docker build time. They are also officially supported and maintained by Python Docker community.

As a workaround we could try using openssl instead of libressl.

Build successful locally using openssl instead of libressl, including removal of cyrus-sasl-plain which is no longer supported for Alpine >= 3.13. Need some testing.

The download / PIP3 upgrade takes a lot of time in total, even when using an optimized cached build. Is there a good reason to upgrade PIP every time, even when using a recent Python image?

nextgens · 2021-08-03T19:06:50Z

The download / PIP3 upgrade takes a lot of time in total, even when using an optimized cached build. Is there a good reason to upgrade PIP every time, even when using a recent Python image?

No. Since this PR is meant to be backported I went for the least intrusive changes I could... but there is no reason for it.

Diman0

lgtm

mergify · 2021-08-04T19:42:41Z

bors r+

bors · 2021-08-04T20:01:46Z

Build succeeded:

CI-Done

nextgens · 2021-08-05T05:59:23Z

@Mergifyio backport 1.8

mergify · 2021-08-05T06:00:16Z

Command backport 1.8: success

Backports have been created

Backport to branch 1.8 not needed, change already in branch 1.8

1908: Optimize docs/Dockerfile r=mergify[bot] a=Erriez - Convert .rst to .html in temporary `python:3.8-alpine3.14` build image - Remove all unused packages - Use `nginx:1.21-alpine` deployment image ## What type of PR? Optimize/fix `docs/Dockerfile` ## What does this PR do? ### Related issue(s) - Mention an issue like: #1851 ## Prerequistes Before we can consider review and merge, please make sure the following list is done and checked. If an entry in not applicable, you can check it or remove it from the list. - [ ] In case of feature or enhancement: documentation updated accordingly - [ ] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/workflow.html#changelog) entry file. ## Testing The following tests has been executed locally: ```bash export DOCKER_ORG=user export DOCKER_PREFIX= export MAILU_VERSION=master cd tests time docker-compose -f build.yml build --no-cache docs real 0m18.850s user 0m0.317s sys 0m0.124s docker images REPOSITORY TAG IMAGE ID CREATED SIZE user/docs master 3de6c8612cf3 19 seconds ago 38.1MB docker run -it --rm --name mailu-docs -p 80:80 user/docs:master Open web browser: Clear caches http://localhost:80/master ``` Co-authored-by: Erriez <Erriez@users.noreply.github.com>

1906: Backport of #1851 r=mergify[bot] a=nextgens mergify seems to have a problem with it so here it is... Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>

nextgens added 2 commits July 5, 2021 15:50

Upgrade to alpine 3.14

420afa5

don't need sudo here

0211c06

nextgens added type/security Related to security type/backport Automatic backport this PR to the current stable release labels Jul 5, 2021

nextgens added this to the 1.8 milestone Jul 5, 2021

bors bot added a commit that referenced this pull request Jul 5, 2021

Try #1851:

9fa270d

nextgens added 2 commits July 5, 2021 17:08

remove cyrus-sasl-plain

72735ab

document

474e5aa

bors bot added a commit that referenced this pull request Jul 5, 2021

Try #1851:

641029d

nextgens added the status/blocked This will block mergify until the label is removed. label Jul 5, 2021

Erriez mentioned this pull request Jul 24, 2021

Adding support for arm64 images #1421

Closed

2 tasks

Erriez mentioned this pull request Jul 24, 2021

Arm32v6/7 or Arm64v8 for docker? #1200

Closed

nextgens mentioned this pull request Jul 30, 2021

Increasing the speed of our CI/CD setup #1830

Closed

nextgens added 2 commits August 3, 2021 13:44

Switch to openssl to workaround alpine #12763

f8362d0

Merge remote-tracking branch 'upstream/master' into upgrade-alpine

d44608e

bors bot added a commit that referenced this pull request Aug 3, 2021

Try #1851:

e5008b1

update arm builds too

defea32

still need pip3

ccb3631

bors bot added a commit that referenced this pull request Aug 3, 2021

Try #1851:

04d576b

nextgens removed the status/blocked This will block mergify until the label is removed. label Aug 3, 2021

doh

2b63280

bors bot added a commit that referenced this pull request Aug 3, 2021

Try #1851:

42e8d44

Diman0 approved these changes Aug 4, 2021

View reviewed changes

bors bot merged commit a226392 into Mailu:master Aug 4, 2021

Erriez mentioned this pull request Aug 5, 2021

Optimize docs/Dockerfile #1908

Merged

2 tasks

bors bot added a commit that referenced this pull request Aug 5, 2021

Merge #1906

1db4c57

1906: Backport of #1851 r=mergify[bot] a=nextgens mergify seems to have a problem with it so here it is... Co-authored-by: Florent Daigniere <nextgens@freenetproject.org>

nextgens deleted the upgrade-alpine branch October 31, 2021 08:46

github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade alpine #1851

Upgrade alpine #1851

nextgens commented Jul 5, 2021 •

edited

Loading

mergify bot commented Jul 5, 2021

bors bot commented Jul 5, 2021

Diman0 commented Jul 5, 2021 •

edited

Loading

Diman0 commented Jul 5, 2021

bors bot commented Jul 5, 2021

Diman0 commented Jul 5, 2021

Diman0 commented Jul 5, 2021

nextgens commented Jul 5, 2021

Erriez commented Jul 24, 2021 •

edited

Loading

nextgens commented Jul 24, 2021

Diman0 commented Aug 3, 2021

nextgens commented Aug 3, 2021

bors bot commented Aug 3, 2021

nextgens commented Aug 3, 2021

mergify bot commented Aug 3, 2021

bors bot commented Aug 3, 2021

bors bot commented Aug 3, 2021

nextgens commented Aug 3, 2021

bors bot commented Aug 3, 2021

Erriez commented Aug 3, 2021 •

edited

Loading

nextgens commented Aug 3, 2021

Diman0 left a comment

mergify bot commented Aug 4, 2021

bors bot commented Aug 4, 2021

nextgens commented Aug 5, 2021

mergify bot commented Aug 5, 2021

Upgrade alpine #1851

Upgrade alpine #1851

Conversation

nextgens commented Jul 5, 2021 • edited Loading

What type of PR?

What does this PR do?

Related issue(s)

Prerequistes

mergify bot commented Jul 5, 2021

bors bot commented Jul 5, 2021

try

Diman0 commented Jul 5, 2021 • edited Loading

Diman0 commented Jul 5, 2021

bors bot commented Jul 5, 2021

try

Diman0 commented Jul 5, 2021

Diman0 commented Jul 5, 2021

nextgens commented Jul 5, 2021

Erriez commented Jul 24, 2021 • edited Loading

nextgens commented Jul 24, 2021

Diman0 commented Aug 3, 2021

nextgens commented Aug 3, 2021

bors bot commented Aug 3, 2021

try

nextgens commented Aug 3, 2021

mergify bot commented Aug 3, 2021

bors bot commented Aug 3, 2021

try

bors bot commented Aug 3, 2021

try

nextgens commented Aug 3, 2021

bors bot commented Aug 3, 2021

try

Erriez commented Aug 3, 2021 • edited Loading

nextgens commented Aug 3, 2021

Diman0 left a comment

Choose a reason for hiding this comment

mergify bot commented Aug 4, 2021

bors bot commented Aug 4, 2021

nextgens commented Aug 5, 2021

mergify bot commented Aug 5, 2021

nextgens commented Jul 5, 2021 •

edited

Loading

Diman0 commented Jul 5, 2021 •

edited

Loading

Erriez commented Jul 24, 2021 •

edited

Loading

Erriez commented Aug 3, 2021 •

edited

Loading