Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alert when incompatible maps are compared in delta view #3771

Open
3 tasks
ChristianHuehn opened this issue Sep 26, 2024 · 3 comments · May be fixed by #3773
Open
3 tasks

Add an alert when incompatible maps are compared in delta view #3771

ChristianHuehn opened this issue Sep 26, 2024 · 3 comments · May be fixed by #3773
Assignees
Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@ChristianHuehn
Copy link
Collaborator

ChristianHuehn commented Sep 26, 2024

Feature request

Description

As a user, I want to see an alert when comparing two maps which have different complexities (mcc and sonar_complexity), so that I can migrate them myself.

Acceptance criteria

  • Alert is only shown in delta mode when selecting a map
  • Alert contains information about the migration and links to the documentation
  • Alert has a close button and a checkbox for "don't remind me again", not opening the window again
@ChristianHuehn ChristianHuehn added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO labels Sep 26, 2024
@polina-schoenfeld-mw polina-schoenfeld-mw self-assigned this Sep 26, 2024
@polina-schoenfeld-mw polina-schoenfeld-mw linked a pull request Sep 30, 2024 that will close this issue
6 tasks
@BridgeAR
Copy link
Member

The migration might be useful for a few parsers but this is specific to a singular situation.

What about instead just showing the users what metrics do not match by highlighting them in a way that they are not clickable and indicate if map A or map B has the metric.
On top of that (as a second step), add a functionality that allows to link the metric to one available in the other map.

That way it's always working for any combination and helps users to identify the issue fast.

@ChristianHuehn
Copy link
Collaborator Author

I agree with you in general, but we will change part of the cc.json format in the future. That would be a better place for this functionality. We spoke with some users and for them it was fine to do it like that right now. Thanks for your feedback.

@BridgeAR
Copy link
Member

BridgeAR commented Oct 1, 2024

I fail to understand how the cc.json format matters in that case. Especially the indication that map A and B do not share the same metric names is something that we have in many situations and one input file has no knowledge about the other one until is it loaded.

I am certain most users are fine with the suggested implementation as it will resolve their immediate need. There are just different ways to resolve that need. One way is specific to that singular metric combination and the other solution is generic to any metric combination and will help future use cases.

CC is a general purpose tool and we have very different use cases (it is even used to visualize financial department data). Thus, generic solutions seem best to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants