From fb168600a02affea8eabb8a86ed9c305c804c9c0 Mon Sep 17 00:00:00 2001 From: Benedikt Mehl Date: Fri, 31 Jan 2025 15:06:18 +0100 Subject: [PATCH] Rename addedFile #3899 --- .../app/codeCharta/services/loadFile/fileParser.ts | 10 +++++----- .../codeCharta/services/loadFile/loadFile.service.ts | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/visualization/app/codeCharta/services/loadFile/fileParser.ts b/visualization/app/codeCharta/services/loadFile/fileParser.ts index fa1f1c3ee3..48bd3b0b8e 100644 --- a/visualization/app/codeCharta/services/loadFile/fileParser.ts +++ b/visualization/app/codeCharta/services/loadFile/fileParser.ts @@ -47,7 +47,7 @@ export function enrichFileStatesAndRecentFilesWithValidationResults( currentFilesAreSampleFilesCallback: () => boolean, setCurrentFilesAreNotSampleFilesCallback: () => void ): boolean { - let newFilesWereAdded = false + let hasAddedAtLeastOneFile = false for (const nameDataPair of nameDataPairs) { const fileValidationResult: FileValidationResult = { fileName: nameDataPair?.fileName, @@ -60,15 +60,15 @@ export function enrichFileStatesAndRecentFilesWithValidationResults( if (fileValidationResult.errors.length === 0) { fileValidationResult.warnings.push(...checkWarnings(nameDataPair?.content)) - const addedFile = addFile( + const hasAddedFile = addFile( fileStates, recentFiles, nameDataPair, currentFilesAreSampleFilesCallback, setCurrentFilesAreNotSampleFilesCallback ) - if (addedFile) { - newFilesWereAdded = true + if (hasAddedFile) { + hasAddedAtLeastOneFile = true } } @@ -76,7 +76,7 @@ export function enrichFileStatesAndRecentFilesWithValidationResults( fileValidationResults.push(fileValidationResult) } } - return newFilesWereAdded + return hasAddedAtLeastOneFile } function addFile( diff --git a/visualization/app/codeCharta/services/loadFile/loadFile.service.ts b/visualization/app/codeCharta/services/loadFile/loadFile.service.ts index ab1b21daf2..c76b525efa 100644 --- a/visualization/app/codeCharta/services/loadFile/loadFile.service.ts +++ b/visualization/app/codeCharta/services/loadFile/loadFile.service.ts @@ -47,7 +47,7 @@ export class LoadFileService implements OnDestroy { const recentFiles: string[] = [] const fileValidationResults: CCFileValidationResult[] = [] - const newFilesWereAdded = enrichFileStatesAndRecentFilesWithValidationResults( + const hasAddedAtLeastOneFile = enrichFileStatesAndRecentFilesWithValidationResults( fileStates, recentFiles, nameDataPairs, @@ -73,7 +73,7 @@ export class LoadFileService implements OnDestroy { this.store.dispatch(setStandardByNames({ fileNames: recentFiles })) fileRoot.updateRoot(rootName) - if (!newFilesWereAdded) { + if (!hasAddedAtLeastOneFile) { throw new Error(FILES_ALREADY_LOADED_ERROR_MESSAGE) } }