Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in MahApps.Templates.ValidationError #3969

Closed
lipchev opened this issue Nov 17, 2020 · 1 comment · Fixed by #3970
Closed

Memory leak in MahApps.Templates.ValidationError #3969

lipchev opened this issue Nov 17, 2020 · 1 comment · Fixed by #3970
Labels
Milestone

Comments

@lipchev
Copy link
Contributor

lipchev commented Nov 17, 2020

Describe the bug

There is a minor memory leak with the default validation error template (MahApps.Templates.ValidationError): the binding mode on this line should be OneTime, as the underlying object (System.Windows.Controls.ValidationError) does not implement INotifyPropertyChanged

Steps to reproduce

Make the red validation popup appear by hovering over a control with a validation error.

Actual behavior

Observed the WPF binding leak is detected by the memory profiler

Environment

MahApps.Metro version: v2.0.0
Windows build number: Win10 1909 [Version 10.0.18363.836]
Visual Studio: 2019 16.6.0
Target Framework: .Net Core 3.1 (v4.5.2, v4.7.2)

Screenshots

image

@lipchev lipchev added the Bug label Nov 17, 2020
@punker76
Copy link
Member

@lipchev Thx for reporting this! If you want to fix this, then create a PR. I'll appreciate it! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants