Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we drop the .Net 4 support? #3041

Closed
punker76 opened this issue Sep 7, 2017 · 30 comments
Closed

Should we drop the .Net 4 support? #3041

punker76 opened this issue Sep 7, 2017 · 30 comments
Assignees
Milestone

Comments

@punker76
Copy link
Member

punker76 commented Sep 7, 2017

You know MahApps.Metro comes with .Net 4 and .Net 4.5, but it was always been laborious.

So should we

👍 drop this
👎 leave this

.Net 4 support?

IMO I think this can be dropped...

Thx

@punker76 punker76 added this to the 1.6.0 milestone Sep 7, 2017
@feinstein
Copy link
Contributor

👍 drop it, but mark the lastest version with .NET 4.0 support with a tag, so if anyone needs it, he can easily use it.

@amkuchta
Copy link
Contributor

amkuchta commented Sep 7, 2017

I agree. Drop it, but tag the last 4 release.

@thoemmi
Copy link
Collaborator

thoemmi commented Sep 7, 2017

Microsoft's support for .NET 4, 4.5, and 4.5.1 ended January 12, 2016 (Source). That's almost 20 month ago. Therefore I'd say drop it.

@thoemmi
Copy link
Collaborator

thoemmi commented Sep 7, 2017

BTW, there are still requests for Windows XP support coming, so tagging the last .NET 4 version would be relieving. 🙄

@jogibear9988
Copy link

increase the major when you drop support...

@punker76
Copy link
Member Author

punker76 commented Sep 7, 2017

@jogibear9988 Yes, v1.6.0 will be the last version with .Net 4.0 support. So v2.0 will drop this... that's the plan.

@ShannonZ
Copy link

ShannonZ commented Sep 8, 2017

Drop it. Don't make large library to implement compatibility.

@ghiboz
Copy link

ghiboz commented Sep 8, 2017

Drop it! 👍

@punker76
Copy link
Member Author

punker76 commented Sep 8, 2017

@Nuklon I'll tag/branch this after 1.6.0 with last dotNet4, but I'll not update this branch any further.

@punker76
Copy link
Member Author

punker76 commented Sep 9, 2017

@Nuklon All async stuff is special handled, there is also a NET4 compiler directive. ControlzEx handles .NET 4 too. Virtualization in styles is special handled and makes it difficult to handle for net 4.5+ I don't think that this would be a shame...

@batzen
Copy link
Collaborator

batzen commented Sep 9, 2017

XP also isn't supported anymore.
Supporting libs on unsupported OS/Framework requires time and does not make a lot of sense IMHO.
If anyone needs it they can vote here to keep it.

@thoemmi
Copy link
Collaborator

thoemmi commented Sep 9, 2017

MahApps.Metro doesn't support Windows XP anymore for quite some time.

@thoemmi
Copy link
Collaborator

thoemmi commented Sep 10, 2017

@Nuklon It may work for you, but it's not supported. There are several issues reported related to Windows XP, but they won't get fixed.

Anyway, the discussion is not about Windows XP but .NET 4.

@alexeygritsenko
Copy link

Hi, this is a very stupid thing! Please do not remove .Net 4.0 support. My program must necessarily work with Windows XP. If you delete something I can not get updates this is bad

@jenokizm
Copy link

Please do not delete it!

@punker76
Copy link
Member Author

@alexeygritsenko @jenokizm Nothing will be delete. The v1.6.0 will be the last version with .Net 4, after this there will be a branch alive which has this in, but it will not be update from me. Feel free to do this and create a PR for this with the latest changes from the upcoming 2.0+

@punker76 punker76 self-assigned this Oct 17, 2017
@Bykiev
Copy link

Bykiev commented Jan 28, 2018

@punker76, I think you should continue to support a .NET 4.0 version: no more new features but still fix the bugs

@batzen
Copy link
Collaborator

batzen commented Jan 28, 2018

@Bykiev he will create a tag in git. But i don't think he will fix bugs there. IMHO he shouldn't fix bugs there. Would you fix bugs in software you don't use and don't get paid to work on?

@Bykiev
Copy link

Bykiev commented Jan 28, 2018

@batzen, of course, no need to support a dead software, but .NET 4.0 isn't dead, at work, we continue to support our software on .NET 4.0 because there is some Windows XP PCs still working even Microsoft dropped it's support.

@batzen
Copy link
Collaborator

batzen commented Jan 28, 2018

@Bykiev .NET 4.0 and Windows XP are dead and shouldn't be used anymore. Still running Windows XP today is kinda insane from a security point of view.

And you didn't answer my question...

@feinstein
Copy link
Contributor

@BatSen, the whole point of open source software is to support the community, not being paid or only fixing what you use.

I agree that supporting windows XP is insane on a technological standpoint, but there are lots of industries still using it and not supporting those clients is insane in a financial standpoint.

@batzen
Copy link
Collaborator

batzen commented Jan 28, 2018

@feinstein Everyone in the world of OSS is free to only fix what he/she likes to fix. That's OSS.

If you demand someone to fix/maintain something for you because it would be insane in a financial standpoint then you obviously should bring some of that financial standpoint to the table, or even better contribute and fix it yourself.

@feinstein
Copy link
Contributor

@batzen, I think you misunderstood my point, I was speaking about 2 separate things.

I personally don't think we should continue to support .NET 4.0 here, but your statement of only supporting thing that we use and care about its not my personal opinion on software quality. This can easily lead to code that looks like Swiss cheese, lots of good cheeses and still lots of holes.

My comments on Windows XP was just to make a statement on why people still support it, even been a security nightmare. And yes, I believe companies that need that support could help financially, so that old code that they need can still be supported, but I didn't want to tie those 2 subjects together.

@batzen
Copy link
Collaborator

batzen commented Jan 28, 2018

@feinstein My initial question to the other guy was like "would you deliver what you demand from others?". Getting no answer to that is enough of an answer.

So you maintain an OSS project where you showcase your opinion about software quality and swiss cheese?

@feinstein
Copy link
Contributor

@BatSen I don't understand your question.

Anyway, anyone interested in the whole .NET 4.0 debate should read the beginning of this thread, where it's clear it won't be supported anymore and only have a tag.

No need to further discuss philosophies here, cluttering people's emails.

@Bykiev
Copy link

Bykiev commented Jan 29, 2018

@batzen, sorry for a long delay, I'm in a different time zone....
I don't understand your question too. Of course, at work I'll not support software which isn't used by anyone. But it's an open source framework, and if community is using it there is no any reasone to not fixing bugs.
I agree with @feinstein, if @punker76 decided to not suppport it on .NET 4.0 we can't do anything except to make own PRs.

@jogibear9988
Copy link

jogibear9988 commented Jan 29, 2018

I don‘t see the Problem here. I don‘t think there are many bugs, or no one of you had used it. So, droppibg support doesn‘t mean to delete it.
As there are no changes in Net 4.0 any more (cause Ms droppef support), your app using this lib will work as before, and you lived with bugs of the lib (if there were any) since months, so why shouldn‘t work for months again.
And if it will not because the bug is really critical, I‘m sure punker (or some other contributor) will help!

@jenokizm
Copy link

Hi guys. Perhaps in some kind of fictional magic world, Windows XP are obsolete and no longer use, but in reality they are often found in other areas. You can look at this question on the other hand, the support of .Net 4.0 allows you to run the application on computers with Windows 7 because this version is on the system by default, and some users are lazy to update .Net.

@Malavos
Copy link

Malavos commented Jan 30, 2018

@jenokizm that's just my opinion, but if you're making a app for someone with XP, you better off using classic WF. You will have some troubles with wpf beyond MahApps on XP. Not to mention the poor perfomance of some libraries and other content.

While I don't personally agree that we should drop 4.0, the commercial and logical standpoint is that we drop it. If Microsoft dropped it, we should not move forward with it. It will free us to develop, fix and try new things out, without "looking back".

That's just my viewpoint. That's why I voted in favor to drop it.

@sbrian26
Copy link

Drop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests