Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrongName signed assembly? Hey, it's 2017... #3029

Closed
punker76 opened this issue Aug 25, 2017 · 3 comments
Closed

StrongName signed assembly? Hey, it's 2017... #3029

punker76 opened this issue Aug 25, 2017 · 3 comments
Milestone

Comments

@punker76
Copy link
Member

punker76 commented Aug 25, 2017

MahApps v1.6.0 will not be strong-named.

Why?

Strong-named assemblies are only useful in some rare scenarios. If you need strong-named assembly then you can compile the source by yourself ore use the Strong Namer from Daniel Plaisted @dsplaisted or Strong-Name Signer from Werner van Deventer @brutaldev.

More informations about the reason of this decision can be found here:

@maggarwal
Copy link

This is really annoying. I have been using this library for years and all our products are signed. Now I have dilemma that should I continue to use this or look for alternatives. Hack you suggest to sign it is not ideal as it does not work in lots of scenarios. What I don't understand is what is the harm having it signed? Also, if there is an issue why not have both versions available so that you are not breaking things for audience who is already using it.

@RuntimeRascal
Copy link

What a bummer. I too have been using MahApps for a few years now and the projects I am working on, COM Addin, require all assemblies to be signed. Putting things in GAC to prevent from needed to simply sign assemblies is not ideal for me. I am in the team of what's the harm. It takes 2.5 seconds in Visual Studio to sign the source and if you think that it is ideal to offer assemblies up through nuget that are not signed, why is MahApps Metro the single only assembly I have ever come across that isn't signed. I am referencing 45 nuget packages including all the Roslyn packages and MahApps is the only problem package. I think I would be hard pressed to find any assembly on my computer that isn't signed.

@LaurelJay
Copy link

And why you listen to their post? Signed assembly is compatible with all project whether it is signed or not. While not signed give headache to all signed obfuscated assemblies. Pls. sign the MahApps again. thanks..

@MahApps MahApps locked and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

4 participants