Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why change App Style in Flyout if the theme Adapt is chosen? #2745

Closed
Anapher opened this issue Nov 15, 2016 · 2 comments
Closed

Why change App Style in Flyout if the theme Adapt is chosen? #2745

Anapher opened this issue Nov 15, 2016 · 2 comments
Labels
Bug
Milestone
1.6.0

Comments

@Anapher
Copy link
Contributor

Anapher commented Nov 15, 2016

I don't get why this line is necessary:
https://github.com/MahApps/MahApps.Metro/blob/develop/src/MahApps.Metro/MahApps.Metro.Shared/Controls/Flyout.cs#L355

It just changes the current theme to the current theme. My problem is that i made my own themes and this is destroying everything because it overrides my theme. Would it be possible to remove that line?
@punker76
Copy link
Member

punker76 commented Apr 13, 2017 •
edited
Loading

@alkalinee Would be nice if you can test the latest source or/and the upcoming 1.5.0

@punker76 punker76 added this to the 1.6.0 milestone Jan 15, 2018
@punker76
Copy link
Member

punker76 commented Jan 15, 2018 •
edited
Loading

This should work now in upcoming v1.6.0 since the Dialog and Flyout controls try to find the current theme. So a custom theme or accent wont be override anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@punker76 @Anapher