From 0a2afbaadd94308a916cb36b5e93405c368866b5 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Sat, 8 Jun 2013 07:41:44 -0500
Subject: [PATCH 1/7] CloseTabCommand should work /better/. All TabControls
 inherit from BaseMetroTabControl in order to make extending the TabControls
 easier.

---
 .../MetroAnimatedSingleRowTabControl.cs       | 27 +--------
 .../Controls/MetroAnimatedTabControl.cs       | 27 +--------
 MahApps.Metro/Controls/MetroTabControl.cs     | 55 ++++++++++++++++---
 MahApps.Metro/Themes/MetroTabItem.xaml        |  4 +-
 4 files changed, 52 insertions(+), 61 deletions(-)

diff --git a/MahApps.Metro/Controls/MetroAnimatedSingleRowTabControl.cs b/MahApps.Metro/Controls/MetroAnimatedSingleRowTabControl.cs
index 27895ccdad..cdb1ed831f 100644
--- a/MahApps.Metro/Controls/MetroAnimatedSingleRowTabControl.cs
+++ b/MahApps.Metro/Controls/MetroAnimatedSingleRowTabControl.cs
@@ -1,38 +1,15 @@
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Data;
 using System.Windows.Input;
 
 namespace MahApps.Metro.Controls
 {
-    public class MetroAnimatedSingleRowTabControl : TabControl
+    public class MetroAnimatedSingleRowTabControl : BaseMetroTabControl
     {
         public MetroAnimatedSingleRowTabControl()
         {
             DefaultStyleKey = typeof(MetroAnimatedSingleRowTabControl);
         }
-        
-        public Thickness TabStripMargin
-        {
-            get { return (Thickness)GetValue(TabStripMarginProperty); }
-            set { SetValue(TabStripMarginProperty, value); }
-        }
-
-        // Using a DependencyProperty as the backing store for TabStripMargin.  This enables animation, styling, binding, etc...
-        public static readonly DependencyProperty TabStripMarginProperty =
-            DependencyProperty.Register("TabStripMargin", typeof(Thickness), typeof(MetroAnimatedSingleRowTabControl), new PropertyMetadata(new Thickness(0)));
-
-        protected override DependencyObject GetContainerForItemOverride()
-        {
-            return new MetroTabItem() { OwningTabControl = this }; //Overrides the TabControl's default behavior and returns a MetroTabItem instead of a regular one.
-        }
-
-        public ICommand CloseTabCommand
-        {
-            get { return (ICommand)GetValue(CloseTabCommandProperty); }
-            set { SetValue(CloseTabCommandProperty, value); }
-        }
-
-        public static readonly DependencyProperty CloseTabCommandProperty =
-            DependencyProperty.Register("CloseTabCommand", typeof(ICommand), typeof(MetroAnimatedSingleRowTabControl), new PropertyMetadata(new MahApps.Metro.Controls.MetroTabControl.DefaultCloseTabCommand()));
     }
 }
diff --git a/MahApps.Metro/Controls/MetroAnimatedTabControl.cs b/MahApps.Metro/Controls/MetroAnimatedTabControl.cs
index 03c33f2897..ffc2aae1b7 100644
--- a/MahApps.Metro/Controls/MetroAnimatedTabControl.cs
+++ b/MahApps.Metro/Controls/MetroAnimatedTabControl.cs
@@ -1,38 +1,15 @@
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Data;
 using System.Windows.Input;
 
 namespace MahApps.Metro.Controls
 {
-    public class MetroAnimatedTabControl : TabControl
+    public class MetroAnimatedTabControl : BaseMetroTabControl
     {
         public MetroAnimatedTabControl()
         {
             DefaultStyleKey = typeof(MetroAnimatedTabControl);
         }
-        
-        public Thickness TabStripMargin
-        {
-            get { return (Thickness)GetValue(TabStripMarginProperty); }
-            set { SetValue(TabStripMarginProperty, value); }
-        }
-
-        // Using a DependencyProperty as the backing store for TabStripMargin.  This enables animation, styling, binding, etc...
-        public static readonly DependencyProperty TabStripMarginProperty =
-            DependencyProperty.Register("TabStripMargin", typeof(Thickness), typeof(MetroAnimatedTabControl), new PropertyMetadata(new Thickness(0)));
-
-        protected override DependencyObject GetContainerForItemOverride()
-        {
-            return new MetroTabItem() { OwningTabControl = this }; //Overrides the TabControl's default behavior and returns a MetroTabItem instead of a regular one.
-        }
-
-        public ICommand CloseTabCommand
-        {
-            get { return (ICommand)GetValue(CloseTabCommandProperty); }
-            set { SetValue(CloseTabCommandProperty, value); }
-        }
-
-        public static readonly DependencyProperty CloseTabCommandProperty =
-            DependencyProperty.Register("CloseTabCommand", typeof(ICommand), typeof(MetroAnimatedTabControl), new PropertyMetadata(new MahApps.Metro.Controls.MetroTabControl.DefaultCloseTabCommand()));
     }
 }
diff --git a/MahApps.Metro/Controls/MetroTabControl.cs b/MahApps.Metro/Controls/MetroTabControl.cs
index d7ef90fde8..793c31cea7 100644
--- a/MahApps.Metro/Controls/MetroTabControl.cs
+++ b/MahApps.Metro/Controls/MetroTabControl.cs
@@ -1,14 +1,23 @@
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Data;
 using System.Windows.Input;
 
 namespace MahApps.Metro.Controls
 {
-    public class MetroTabControl : TabControl
+    public class MetroTabControl : BaseMetroTabControl
     {
-        public MetroTabControl()
+        public MetroTabControl():base()
         {
-            DefaultStyleKey = typeof(MetroTabControl);
+            DefaultStyleKey = typeof(MetroTabControl);         
+        }
+    }
+
+    public abstract class BaseMetroTabControl: TabControl
+    {
+        public BaseMetroTabControl()
+        {
+            InternalCloseTabCommand = new DefaultCloseTabCommand(this);
         }
 
         public Thickness TabStripMargin
@@ -19,13 +28,19 @@ public Thickness TabStripMargin
 
         // Using a DependencyProperty as the backing store for TabStripMargin.  This enables animation, styling, binding, etc...
         public static readonly DependencyProperty TabStripMarginProperty =
-            DependencyProperty.Register("TabStripMargin", typeof(Thickness), typeof(MetroTabControl), new PropertyMetadata(new Thickness(0)));
+            DependencyProperty.Register("TabStripMargin", typeof(Thickness), typeof(BaseMetroTabControl), new PropertyMetadata(new Thickness(0)));
 
         protected override DependencyObject GetContainerForItemOverride()
         {
             return new MetroTabItem() { OwningTabControl = this }; //Overrides the TabControl's default behavior and returns a MetroTabItem instead of a regular one.
         }
 
+        protected override void PrepareContainerForItemOverride(DependencyObject element, object item)
+        {
+            element.SetCurrentValue(MetroTabItem.DataContextProperty, item);
+            base.PrepareContainerForItemOverride(element, item);
+        }
+
         public ICommand CloseTabCommand
         {
             get { return (ICommand)GetValue(CloseTabCommandProperty); }
@@ -33,10 +48,25 @@ public ICommand CloseTabCommand
         }
 
         public static readonly DependencyProperty CloseTabCommandProperty =
-            DependencyProperty.Register("CloseTabCommand", typeof(ICommand), typeof(MetroTabControl), new PropertyMetadata(new DefaultCloseTabCommand()));
+            DependencyProperty.Register("CloseTabCommand", typeof(ICommand), typeof(BaseMetroTabControl), new PropertyMetadata(null));
+
+        private ICommand InternalCloseTabCommand
+        {
+            get { return (ICommand)GetValue(InternalCloseTabCommandProperty); }
+            set { SetValue(InternalCloseTabCommandProperty, value); }
+        }
+        private static readonly DependencyProperty InternalCloseTabCommandProperty =
+            DependencyProperty.Register("InternalCloseTabCommand", typeof(ICommand), typeof(BaseMetroTabControl), new PropertyMetadata(null));
+
 
         internal class DefaultCloseTabCommand : ICommand
         {
+            private BaseMetroTabControl owner = null;
+            internal DefaultCloseTabCommand(BaseMetroTabControl Owner)
+            {
+                owner = Owner;
+            }
+
             public bool CanExecute(object parameter)
             {
                 return true;
@@ -46,11 +76,18 @@ public bool CanExecute(object parameter)
 
             public void Execute(object parameter)
             {
-                if (parameter != null && parameter is MetroTabItem)
+                if (parameter != null)
                 {
-                    var tabItem = (MetroTabItem)parameter;
-
-                    ((TabControl)tabItem.OwningTabControl).Items.Remove(tabItem);
+                    if (owner.CloseTabCommand != null)
+                        owner.CloseTabCommand.Execute(parameter);
+                    else
+                    {
+                        if (parameter is MetroTabItem)
+                        {
+                            var tabItem = (MetroTabItem)parameter;
+                            owner.Items.Remove(tabItem);
+                        }
+                    }
                 }
             }
         }
diff --git a/MahApps.Metro/Themes/MetroTabItem.xaml b/MahApps.Metro/Themes/MetroTabItem.xaml
index 7e2b7ef498..0f6d0599b2 100644
--- a/MahApps.Metro/Themes/MetroTabItem.xaml
+++ b/MahApps.Metro/Themes/MetroTabItem.xaml
@@ -23,8 +23,8 @@
                         <Button x:Name="PART_CloseButton" Style="{DynamicResource ChromelessButtonStyle}" Foreground="{TemplateBinding Foreground}" Width="20"  
                                 HorizontalAlignment="Right"  FontFamily="Marlett" Content="r" FontSize="17" Margin="0 0 2 0"
                                 Visibility="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(CloseButtonEnabled), Converter={StaticResource BooleanToVisibilityConverter}}" 
-                                IsTabStop="False" Command="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type TabControl}}, Path=CloseTabCommand}" 
-                                CommandParameter="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type TabItem}}}" VerticalAlignment="Top" />
+                                IsTabStop="False" Command="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type TabControl}}, Path=InternalCloseTabCommand}" 
+                                CommandParameter="{Binding .}" VerticalAlignment="Top" />
                     </StackPanel>
                     <ControlTemplate.Triggers>
                         <Trigger Property="IsSelected" Value="true">

From 675692ca9451a99938eeaa70af341d07d7a944a3 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Sat, 8 Jun 2013 08:17:30 -0500
Subject: [PATCH 2/7] Reworked TabItem Close button infrastructure. Close
 Button isn't show until the tab is selected or has mouse hover.
 CloseTabCommand is only called on MVVM Data Bound items.

---
 MahApps.Metro/Controls/MetroTabControl.cs | 41 +++++++++++--
 MahApps.Metro/Controls/MetroTabItem.cs    | 75 ++++++++++++++++++++++-
 MahApps.Metro/Themes/MetroTabItem.xaml    |  4 +-
 3 files changed, 110 insertions(+), 10 deletions(-)

diff --git a/MahApps.Metro/Controls/MetroTabControl.cs b/MahApps.Metro/Controls/MetroTabControl.cs
index 793c31cea7..1a3fc465a3 100644
--- a/MahApps.Metro/Controls/MetroTabControl.cs
+++ b/MahApps.Metro/Controls/MetroTabControl.cs
@@ -1,4 +1,5 @@
-using System.Windows;
+using System;
+using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Data;
 using System.Windows.Input;
@@ -18,6 +19,32 @@ public abstract class BaseMetroTabControl: TabControl
         public BaseMetroTabControl()
         {
             InternalCloseTabCommand = new DefaultCloseTabCommand(this);
+
+            this.Loaded += BaseMetroTabControl_Loaded;
+            this.Unloaded += BaseMetroTabControl_Unloaded;
+        }
+
+        void BaseMetroTabControl_Unloaded(object sender, RoutedEventArgs e)
+        {
+            this.Loaded -= BaseMetroTabControl_Loaded;
+            this.Unloaded -= BaseMetroTabControl_Unloaded;
+        }
+
+        void BaseMetroTabControl_Loaded(object sender, RoutedEventArgs e)
+        {
+            this.Loaded += BaseMetroTabControl_Loaded;
+
+            //Ensure each tabitem knows what the owning tab is.
+            try
+            {
+                if (ItemsSource == null)
+                    foreach (TabItem item in Items)
+                        if (item is MetroTabItem)
+                        ((MetroTabItem)item).OwningTabControl = this;
+            }
+            catch (Exception)
+            {
+            }
         }
 
         public Thickness TabStripMargin
@@ -50,7 +77,7 @@ public ICommand CloseTabCommand
         public static readonly DependencyProperty CloseTabCommandProperty =
             DependencyProperty.Register("CloseTabCommand", typeof(ICommand), typeof(BaseMetroTabControl), new PropertyMetadata(null));
 
-        private ICommand InternalCloseTabCommand
+        internal ICommand InternalCloseTabCommand
         {
             get { return (ICommand)GetValue(InternalCloseTabCommandProperty); }
             set { SetValue(InternalCloseTabCommandProperty, value); }
@@ -78,13 +105,15 @@ public void Execute(object parameter)
             {
                 if (parameter != null)
                 {
-                    if (owner.CloseTabCommand != null)
-                        owner.CloseTabCommand.Execute(parameter);
+                    Tuple<object, MetroTabItem> paramData = (Tuple<object, MetroTabItem>)parameter;
+
+                    if (owner.CloseTabCommand != null && !(paramData.Item1 is TextBlock)) //best way I could tell if the tabitem is from databinding or not.
+                        owner.CloseTabCommand.Execute(paramData.Item1);
                     else
                     {
-                        if (parameter is MetroTabItem)
+                        if (paramData.Item2 is MetroTabItem)
                         {
-                            var tabItem = (MetroTabItem)parameter;
+                            var tabItem = (MetroTabItem)paramData.Item2;
                             owner.Items.Remove(tabItem);
                         }
                     }
diff --git a/MahApps.Metro/Controls/MetroTabItem.cs b/MahApps.Metro/Controls/MetroTabItem.cs
index 018b338193..707c388464 100644
--- a/MahApps.Metro/Controls/MetroTabItem.cs
+++ b/MahApps.Metro/Controls/MetroTabItem.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Windows;
 using System.Windows.Controls;
+using System.Windows.Media;
 
 namespace MahApps.Metro.Controls
 {
@@ -9,6 +10,27 @@ public class MetroTabItem : TabItem
         public MetroTabItem()
         {
             DefaultStyleKey = typeof(MetroTabItem);
+            this.Unloaded += MetroTabItem_Unloaded;
+            this.Loaded += MetroTabItem_Loaded;
+        }
+
+        void MetroTabItem_Loaded(object sender, RoutedEventArgs e)
+        {
+            if (closeButton != null && closeButtonClickUnloaded)
+            {
+                closeButton.Click += closeButton_Click;
+
+                closeButtonClickUnloaded = false;
+            }
+        }
+
+        void MetroTabItem_Unloaded(object sender, RoutedEventArgs e)
+        {
+            this.Loaded -= MetroTabItem_Loaded;
+            this.Unloaded -= MetroTabItem_Unloaded;
+            closeButton.Click -= closeButton_Click;
+
+            closeButtonClickUnloaded = true;
         }
 
         public double HeaderFontSize
@@ -54,17 +76,68 @@ public bool CloseButtonEnabled
         internal Button closeButton = null;
         internal Thickness newButtonMargin;
         internal Label rootLabel = null;
+        private bool closeButtonClickUnloaded = false;
 
         public override void OnApplyTemplate()
         {
             base.OnApplyTemplate();
 
+            bool closeButtonNullBefore = closeButton == null; //TabControl's multi-loading/unloading issue
+
             closeButton = GetTemplateChild("PART_CloseButton") as Button;
             closeButton.Margin = newButtonMargin;
 
+            if (closeButtonNullBefore)
+                closeButton.Click += closeButton_Click;
+
+
+            closeButton.Visibility = CloseButtonEnabled ? System.Windows.Visibility.Visible : System.Windows.Visibility.Hidden;
+
             rootLabel = GetTemplateChild("root") as Label;
         }
 
-        public TabControl OwningTabControl { get; internal set; }
+        void closeButton_Click(object sender, RoutedEventArgs e)
+        {
+            //Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type TabControl}}, Path=InternalCloseTabCommand
+            OwningTabControl.InternalCloseTabCommand.Execute(new Tuple<object, MetroTabItem>(this.Content, this));
+        }
+
+        public BaseMetroTabControl OwningTabControl { get; internal set; }
+
+        protected override void OnSelected(RoutedEventArgs e)
+        {
+            if (closeButton != null)
+                if (CloseButtonEnabled)
+                    closeButton.Visibility = System.Windows.Visibility.Visible;
+
+            base.OnSelected(e);
+        }
+
+        protected override void OnUnselected(RoutedEventArgs e)
+        {
+            if (closeButton != null)
+                closeButton.Visibility = System.Windows.Visibility.Hidden;
+
+            base.OnUnselected(e);
+        }
+
+        protected override void OnMouseEnter(System.Windows.Input.MouseEventArgs e)
+        {
+            if (closeButton != null)
+                if (CloseButtonEnabled)
+                    closeButton.Visibility = System.Windows.Visibility.Visible;
+
+            base.OnMouseEnter(e);
+        }
+
+        protected override void OnMouseLeave(System.Windows.Input.MouseEventArgs e)
+        {
+            if (!this.IsSelected)
+                if (closeButton != null)
+                    if (CloseButtonEnabled)
+                        closeButton.Visibility = System.Windows.Visibility.Hidden;
+
+            base.OnMouseLeave(e);
+        }
     }
 }
diff --git a/MahApps.Metro/Themes/MetroTabItem.xaml b/MahApps.Metro/Themes/MetroTabItem.xaml
index 0f6d0599b2..f400ae09a1 100644
--- a/MahApps.Metro/Themes/MetroTabItem.xaml
+++ b/MahApps.Metro/Themes/MetroTabItem.xaml
@@ -22,9 +22,7 @@
                         </Label>
                         <Button x:Name="PART_CloseButton" Style="{DynamicResource ChromelessButtonStyle}" Foreground="{TemplateBinding Foreground}" Width="20"  
                                 HorizontalAlignment="Right"  FontFamily="Marlett" Content="r" FontSize="17" Margin="0 0 2 0"
-                                Visibility="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(CloseButtonEnabled), Converter={StaticResource BooleanToVisibilityConverter}}" 
-                                IsTabStop="False" Command="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type TabControl}}, Path=InternalCloseTabCommand}" 
-                                CommandParameter="{Binding .}" VerticalAlignment="Top" />
+                                IsTabStop="False" VerticalAlignment="Top" />
                     </StackPanel>
                     <ControlTemplate.Triggers>
                         <Trigger Property="IsSelected" Value="true">

From 007c87b06d1c7dab91b62ef538d40ac235a74b72 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Sat, 8 Jun 2013 08:42:49 -0500
Subject: [PATCH 3/7] Added a TabItemClosingEvent where the user can cancel the
 closing of a TabItem for non-databound TabItems.

---
 MahApps.Metro/Controls/MetroTabControl.cs | 55 +++++++++++++++++------
 samples/MetroDemo/MainWindow.xaml         |  4 +-
 samples/MetroDemo/MainWindow.xaml.cs      |  6 +++
 3 files changed, 49 insertions(+), 16 deletions(-)

diff --git a/MahApps.Metro/Controls/MetroTabControl.cs b/MahApps.Metro/Controls/MetroTabControl.cs
index 1a3fc465a3..2548776496 100644
--- a/MahApps.Metro/Controls/MetroTabControl.cs
+++ b/MahApps.Metro/Controls/MetroTabControl.cs
@@ -1,4 +1,5 @@
 using System;
+using System.ComponentModel;
 using System.Windows;
 using System.Windows.Controls;
 using System.Windows.Data;
@@ -8,13 +9,14 @@ namespace MahApps.Metro.Controls
 {
     public class MetroTabControl : BaseMetroTabControl
     {
-        public MetroTabControl():base()
+        public MetroTabControl()
+            : base()
         {
-            DefaultStyleKey = typeof(MetroTabControl);         
+            DefaultStyleKey = typeof(MetroTabControl);
         }
     }
 
-    public abstract class BaseMetroTabControl: TabControl
+    public abstract class BaseMetroTabControl : TabControl
     {
         public BaseMetroTabControl()
         {
@@ -35,16 +37,12 @@ void BaseMetroTabControl_Loaded(object sender, RoutedEventArgs e)
             this.Loaded += BaseMetroTabControl_Loaded;
 
             //Ensure each tabitem knows what the owning tab is.
-            try
-            {
-                if (ItemsSource == null)
-                    foreach (TabItem item in Items)
-                        if (item is MetroTabItem)
+
+            if (ItemsSource == null)
+                foreach (TabItem item in Items)
+                    if (item is MetroTabItem)
                         ((MetroTabItem)item).OwningTabControl = this;
-            }
-            catch (Exception)
-            {
-            }
+
         }
 
         public Thickness TabStripMargin
@@ -86,6 +84,32 @@ internal ICommand InternalCloseTabCommand
             DependencyProperty.Register("InternalCloseTabCommand", typeof(ICommand), typeof(BaseMetroTabControl), new PropertyMetadata(null));
 
 
+        public delegate void TabItemClosingEventHandler(object sender, TabItemClosingEventArgs e);
+        public event TabItemClosingEventHandler TabItemClosingEvent;
+
+        internal bool RaiseTabItemClosingEvent(MetroTabItem closingItem)
+        {
+            foreach (TabItemClosingEventHandler subHandler in TabItemClosingEvent.GetInvocationList())
+            {
+                TabItemClosingEventArgs args = new TabItemClosingEventArgs(closingItem);
+                subHandler.Invoke(this, args);
+                if (args.Cancel)
+                    return true;
+            }
+
+            return false;
+        }
+
+        public class TabItemClosingEventArgs : CancelEventArgs
+        {
+            internal TabItemClosingEventArgs(MetroTabItem item)
+            {
+                ClosingTabItem = item;
+            }
+
+            public MetroTabItem ClosingTabItem { get; private set; }
+        }
+
         internal class DefaultCloseTabCommand : ICommand
         {
             private BaseMetroTabControl owner = null;
@@ -113,8 +137,11 @@ public void Execute(object parameter)
                     {
                         if (paramData.Item2 is MetroTabItem)
                         {
-                            var tabItem = (MetroTabItem)paramData.Item2;
-                            owner.Items.Remove(tabItem);
+                            if (!owner.RaiseTabItemClosingEvent((MetroTabItem)paramData.Item2)) //Allows the user to cancel closing a tab.
+                            {
+                                var tabItem = (MetroTabItem)paramData.Item2;
+                                owner.Items.Remove(tabItem);
+                            }
                         }
                     }
                 }
diff --git a/samples/MetroDemo/MainWindow.xaml b/samples/MetroDemo/MainWindow.xaml
index 3fdb53af24..6e8be79264 100644
--- a/samples/MetroDemo/MainWindow.xaml
+++ b/samples/MetroDemo/MainWindow.xaml
@@ -595,7 +595,7 @@
                                 </Controls:MetroAnimatedSingleRowTabControl>
                             </Grid>
                             <Label Content="TabControl w/ Closable Items" Style="{StaticResource DescriptionHeaderStyle}" />
-                            <Controls:MetroTabControl>
+                            <Controls:MetroTabControl TabItemClosingEvent="MetroTabControl_TabItemClosingEvent">
                                 <!-- CloseTabCommand="{Binding CloseTabCommand}"-->
                                 <Controls:MetroTabItem Header="headers" HeaderFontSize="20" CloseButtonEnabled="True">
                                     <TextBlock FontSize="30" Text="Content" />
@@ -613,7 +613,7 @@
                                     <TextBlock FontSize="30" Text="Content!" />
                                 </Controls:MetroTabItem>
                                 <Controls:MetroTabItem Header="sizes" HeaderFontSize="30" CloseButtonEnabled="True">
-                                    <TextBlock FontSize="30" Text="This is not content (it is)" />
+                                    <TextBlock FontSize="30" Text="This is not content (it is). This one won't close." />
                                 </Controls:MetroTabItem>
                             </Controls:MetroTabControl>
                         </StackPanel>
diff --git a/samples/MetroDemo/MainWindow.xaml.cs b/samples/MetroDemo/MainWindow.xaml.cs
index 07efee6cd1..f2e14e51a5 100644
--- a/samples/MetroDemo/MainWindow.xaml.cs
+++ b/samples/MetroDemo/MainWindow.xaml.cs
@@ -117,5 +117,11 @@ private void FlipView_SelectionChanged(object sender, SelectionChangedEventArgs
                     break;
             }
         }
+
+        private void MetroTabControl_TabItemClosingEvent(object sender, BaseMetroTabControl.TabItemClosingEventArgs e)
+        {
+            if (e.ClosingTabItem.Header.ToString().StartsWith("sizes"))
+                e.Cancel = true;
+        }
     }
 }

From 590e5187124cd2219745dc944d333f649a05c379 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Sat, 8 Jun 2013 12:10:23 -0500
Subject: [PATCH 4/7] A MetroTabItem is only auto-generated from data bound
 items.

---
 MahApps.Metro/Controls/MetroTabControl.cs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MahApps.Metro/Controls/MetroTabControl.cs b/MahApps.Metro/Controls/MetroTabControl.cs
index 2548776496..d3ff132b64 100644
--- a/MahApps.Metro/Controls/MetroTabControl.cs
+++ b/MahApps.Metro/Controls/MetroTabControl.cs
@@ -55,6 +55,11 @@ public Thickness TabStripMargin
         public static readonly DependencyProperty TabStripMarginProperty =
             DependencyProperty.Register("TabStripMargin", typeof(Thickness), typeof(BaseMetroTabControl), new PropertyMetadata(new Thickness(0)));
 
+        protected override bool IsItemItsOwnContainerOverride(object item)
+        {
+            return item is TabItem;
+        }
+
         protected override DependencyObject GetContainerForItemOverride()
         {
             return new MetroTabItem() { OwningTabControl = this }; //Overrides the TabControl's default behavior and returns a MetroTabItem instead of a regular one.

From 1034da9a9fef749d29f72efe965ccfe7718f7e71 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Sat, 8 Jun 2013 12:24:54 -0500
Subject: [PATCH 5/7] Fixed the TabItem datacontext issue for now. Temporarily
 worked around the TabControl Unload issue.

---
 MahApps.Metro/Controls/MetroTabControl.cs |  4 +++-
 MahApps.Metro/Controls/MetroTabItem.cs    | 14 +++++++++++++-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/MahApps.Metro/Controls/MetroTabControl.cs b/MahApps.Metro/Controls/MetroTabControl.cs
index d3ff132b64..9640c56f76 100644
--- a/MahApps.Metro/Controls/MetroTabControl.cs
+++ b/MahApps.Metro/Controls/MetroTabControl.cs
@@ -67,7 +67,9 @@ protected override DependencyObject GetContainerForItemOverride()
 
         protected override void PrepareContainerForItemOverride(DependencyObject element, object item)
         {
-            element.SetCurrentValue(MetroTabItem.DataContextProperty, item);
+            if (element != item)
+                element.SetCurrentValue(MetroTabItem.DataContextProperty, item); //dont want to set the datacontext to itself.
+
             base.PrepareContainerForItemOverride(element, item);
         }
 
diff --git a/MahApps.Metro/Controls/MetroTabItem.cs b/MahApps.Metro/Controls/MetroTabItem.cs
index 707c388464..4e870168d6 100644
--- a/MahApps.Metro/Controls/MetroTabItem.cs
+++ b/MahApps.Metro/Controls/MetroTabItem.cs
@@ -26,13 +26,25 @@ void MetroTabItem_Loaded(object sender, RoutedEventArgs e)
 
         void MetroTabItem_Unloaded(object sender, RoutedEventArgs e)
         {
-            this.Loaded -= MetroTabItem_Loaded;
             this.Unloaded -= MetroTabItem_Unloaded;
             closeButton.Click -= closeButton_Click;
 
             closeButtonClickUnloaded = true;
         }
 
+        private delegate void EmptyDelegate();
+        ~MetroTabItem()
+        {
+            try
+            {
+                Application.Current.Dispatcher.Invoke(new EmptyDelegate(() =>
+                {
+                    this.Loaded -= MetroTabItem_Loaded;
+                }));
+            }
+            catch (Exception) { }
+        }
+
         public double HeaderFontSize
         {
             get { return (double)GetValue(HeaderFontSizeProperty); }

From 08cf7127b794f20de95062f2494310e4812a0758 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Mon, 10 Jun 2013 12:11:07 -0500
Subject: [PATCH 6/7] Added TabStripPlacement to the Metro*TabControls that did
 not have it. Fixes #527

---
 .../MetroAnimatedSingleRowTabControl.xaml     | 41 ++++++++++++++++---
 MahApps.Metro/Themes/MetroTabControl.xaml     | 31 ++++++++++++++
 samples/MetroDemo/MainWindow.xaml             |  2 +-
 3 files changed, 68 insertions(+), 6 deletions(-)

diff --git a/MahApps.Metro/Themes/MetroAnimatedSingleRowTabControl.xaml b/MahApps.Metro/Themes/MetroAnimatedSingleRowTabControl.xaml
index a69e2a94e2..ba49ff1a1e 100644
--- a/MahApps.Metro/Themes/MetroAnimatedSingleRowTabControl.xaml
+++ b/MahApps.Metro/Themes/MetroAnimatedSingleRowTabControl.xaml
@@ -75,17 +75,17 @@
                 <ControlTemplate TargetType="{x:Type Controls:MetroAnimatedSingleRowTabControl}">
                     <Grid KeyboardNavigation.TabNavigation="Local">
                         <Grid.ColumnDefinitions>
-                            <ColumnDefinition/>
-                            <ColumnDefinition Width="0"/>
+                            <ColumnDefinition x:Name="ColumnDefinition0"/>
+                            <ColumnDefinition x:Name="ColumnDefinition1"  Width="0"/>
                         </Grid.ColumnDefinitions>
                         <Grid.RowDefinitions>
-                            <RowDefinition Height="Auto"/>
-                            <RowDefinition Height="*"/>
+                            <RowDefinition x:Name="RowDefinition0" Height="Auto"/>
+                            <RowDefinition x:Name="RowDefinition1" Height="*"/>
                         </Grid.RowDefinitions>
                         <ScrollViewer Margin="{TemplateBinding TabStripMargin}" VerticalScrollBarVisibility="Disabled" HorizontalScrollBarVisibility="Auto" Template="{DynamicResource ScrollViewerTemplate}">
                             <TabPanel x:Name="HeaderPanel" IsItemsHost="True" Panel.ZIndex="1" Grid.Column="0" Grid.Row="0" KeyboardNavigation.TabIndex="1"/>
                         </ScrollViewer>
-                        <Controls:MetroContentControl Behaviours:ReloadBehavior.OnSelectedTabChanged="True" Grid.Column="0" Grid.Row="1">
+                        <Controls:MetroContentControl x:Name="ContentPanel" Behaviours:ReloadBehavior.OnSelectedTabChanged="True" Grid.Column="0" Grid.Row="1">
                             <ContentPresenter x:Name="PART_SelectedContentHost"
                                     ContentTemplate="{TemplateBinding SelectedContentTemplate}"
                                     Content="{TemplateBinding SelectedContent}"
@@ -95,6 +95,37 @@
                                     SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}" />
                         </Controls:MetroContentControl>
                     </Grid>
+                    <ControlTemplate.Triggers>
+                        <Trigger Property="TabStripPlacement" Value="Bottom">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="1"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="Auto"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="2,0,2,2"/>
+                        </Trigger>
+                        <Trigger Property="TabStripPlacement" Value="Left">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="ContentPanel" Value="1"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition0" Value="Auto"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition1" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="0"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="2,2,0,2"/>
+                        </Trigger>
+                        <Trigger Property="TabStripPlacement" Value="Right">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="HeaderPanel" Value="1"/>
+                            <Setter Property="Grid.Column" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition0" Value="*"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition1" Value="Auto"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="0"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="0,2,2,2"/>
+                        </Trigger>
+                    </ControlTemplate.Triggers>
                 </ControlTemplate>
             </Setter.Value>
         </Setter>
diff --git a/MahApps.Metro/Themes/MetroTabControl.xaml b/MahApps.Metro/Themes/MetroTabControl.xaml
index 50e1a8acac..af1a3cfda3 100644
--- a/MahApps.Metro/Themes/MetroTabControl.xaml
+++ b/MahApps.Metro/Themes/MetroTabControl.xaml
@@ -23,6 +23,37 @@
                             <ContentPresenter x:Name="PART_SelectedContentHost" ContentSource="SelectedContent" Margin="{TemplateBinding Padding}" SnapsToDevicePixels="{TemplateBinding SnapsToDevicePixels}"/>
                         </Border>
                     </Grid>
+                    <ControlTemplate.Triggers>
+                        <Trigger Property="TabStripPlacement" Value="Bottom">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="1"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="Auto"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="2,0,2,2"/>
+                        </Trigger>
+                        <Trigger Property="TabStripPlacement" Value="Left">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="ContentPanel" Value="1"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition0" Value="Auto"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition1" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="0"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="2,2,0,2"/>
+                        </Trigger>
+                        <Trigger Property="TabStripPlacement" Value="Right">
+                            <Setter Property="Grid.Row" TargetName="HeaderPanel" Value="0"/>
+                            <Setter Property="Grid.Row" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Grid.Column" TargetName="HeaderPanel" Value="1"/>
+                            <Setter Property="Grid.Column" TargetName="ContentPanel" Value="0"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition0" Value="*"/>
+                            <Setter Property="Width" TargetName="ColumnDefinition1" Value="Auto"/>
+                            <Setter Property="Height" TargetName="RowDefinition0" Value="*"/>
+                            <Setter Property="Height" TargetName="RowDefinition1" Value="0"/>
+                            <Setter Property="Margin" TargetName="HeaderPanel" Value="0,2,2,2"/>
+                        </Trigger>
+                    </ControlTemplate.Triggers>
                 </ControlTemplate>
             </Setter.Value>
         </Setter>
diff --git a/samples/MetroDemo/MainWindow.xaml b/samples/MetroDemo/MainWindow.xaml
index 6e8be79264..cdad343552 100644
--- a/samples/MetroDemo/MainWindow.xaml
+++ b/samples/MetroDemo/MainWindow.xaml
@@ -68,7 +68,7 @@
                     </MenuItem>
                 </MenuItem>
             </Menu>
-            <Controls:MetroAnimatedSingleRowTabControl Grid.Row="1">
+            <Controls:MetroAnimatedSingleRowTabControl Grid.Row="1" TabStripPlacement="Left">
                 <TabItem Header="buttons">
                     <Grid>
                         <Grid.ColumnDefinitions>

From 02e9cb38f8fed1d8f025096d0bb2e6018cf60b03 Mon Sep 17 00:00:00 2001
From: Amrykid <amrykid@gmail.com>
Date: Mon, 10 Jun 2013 12:13:05 -0500
Subject: [PATCH 7/7] Oops, forgot to remove the TabStripPlacement from
 MainWindow.xaml.

---
 samples/MetroDemo/MainWindow.xaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/MetroDemo/MainWindow.xaml b/samples/MetroDemo/MainWindow.xaml
index cdad343552..6e8be79264 100644
--- a/samples/MetroDemo/MainWindow.xaml
+++ b/samples/MetroDemo/MainWindow.xaml
@@ -68,7 +68,7 @@
                     </MenuItem>
                 </MenuItem>
             </Menu>
-            <Controls:MetroAnimatedSingleRowTabControl Grid.Row="1" TabStripPlacement="Left">
+            <Controls:MetroAnimatedSingleRowTabControl Grid.Row="1">
                 <TabItem Header="buttons">
                     <Grid>
                         <Grid.ColumnDefinitions>