Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for field measurements #36

Closed
jonschumacher opened this issue May 10, 2021 · 2 comments · Fixed by #42
Closed

Add support for field measurements #36

jonschumacher opened this issue May 10, 2021 · 2 comments · Fixed by #42

Comments

@jonschumacher
Copy link
Member

During our discussions on MagneticParticleImaging/MPIMeasurements.jl#27, @jusack and me came across the definition of the field measurement format. Should this be moved over to MPIFiles or stay in MPIMeasurements? Do you see cases where there should be more information stored in the file than what is currently being done? I guess timestamp, currents and fieldsError could be optional.

@tknopp
Copy link
Member

tknopp commented May 10, 2021

Good question. Originally I would have said: No it does not belong into MPIFiles, since MPIFiles ist only for storing MPI measurements. But right now I am not so sure anymore. If we do move it we do need some documentation on the available data formats (which we need anyway). Transfer functions are also stored in hdf5 in MPIFiles.

@jonschumacher
Copy link
Member Author

Alright, I will wait until we have our new gaussmeter and then compare if I see any other fields that might be necessary while acquiring data. Then I will create something and open a PR for a discussion on it.

@jonschumacher jonschumacher self-assigned this May 19, 2021
@jonschumacher jonschumacher linked a pull request Sep 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants