You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #106 updates String_To_Int to be read to INT64 instead of INT32. The current behavior without this change is to overflow to negatives if the number in the input string is too large to be represented by INT32, and this occurs in some of the examples because they provide random number seeds that are large enough to cause this overflow. Until recently, this hasn't been very problematic because the overflow was consistent, but now it causes failures in the test suite for PR #106 , where the overflow was removed, causing the seeds provided in the input file to be the seeds that are actually effectively used, which is not the case where the overflow is present.
The examples in the test suite need to be corrected to provide smaller seeds that do not cause overflow so that they don't cause test suite failures when the update to String_To_Int in PR #106 is made.
The text was updated successfully, but these errors were encountered:
PR #106 updates
String_To_Int
to be read toINT64
instead ofINT32
. The current behavior without this change is to overflow to negatives if the number in the input string is too large to be represented by INT32, and this occurs in some of the examples because they provide random number seeds that are large enough to cause this overflow. Until recently, this hasn't been very problematic because the overflow was consistent, but now it causes failures in the test suite for PR #106 , where the overflow was removed, causing the seeds provided in the input file to be the seeds that are actually effectively used, which is not the case where the overflow is present.The examples in the test suite need to be corrected to provide smaller seeds that do not cause overflow so that they don't cause test suite failures when the update to
String_To_Int
in PR #106 is made.The text was updated successfully, but these errors were encountered: