Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct examples to only use seeds that can be stored as INT32 #107

Closed
rwsmith7531 opened this issue Jul 7, 2021 · 0 comments · Fixed by #108
Closed

Correct examples to only use seeds that can be stored as INT32 #107

rwsmith7531 opened this issue Jul 7, 2021 · 0 comments · Fixed by #108
Assignees

Comments

@rwsmith7531
Copy link
Contributor

PR #106 updates String_To_Int to be read to INT64 instead of INT32. The current behavior without this change is to overflow to negatives if the number in the input string is too large to be represented by INT32, and this occurs in some of the examples because they provide random number seeds that are large enough to cause this overflow. Until recently, this hasn't been very problematic because the overflow was consistent, but now it causes failures in the test suite for PR #106 , where the overflow was removed, causing the seeds provided in the input file to be the seeds that are actually effectively used, which is not the case where the overflow is present.

The examples in the test suite need to be corrected to provide smaller seeds that do not cause overflow so that they don't cause test suite failures when the update to String_To_Int in PR #106 is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant