Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon support #62

Closed
Keith-CY opened this issue Oct 8, 2022 · 11 comments
Closed

Apple Silicon support #62

Keith-CY opened this issue Oct 8, 2022 · 11 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Oct 8, 2022

Package for Apple Silicon: https://www.electronjs.org/blog/apple-silicon

Could have a try on building a universal app: electron-userland/electron-builder#5481

Pay attention to a bug of auto update: electron-userland/electron-builder#5689 (comment)

@Keith-CY Keith-CY added the enhancement New feature or request label Oct 8, 2022
@Keith-CY Keith-CY added this to the 2022/10/12 - 2022/10/19 milestone Oct 8, 2022
@yanguoyu
Copy link

yanguoyu commented Oct 8, 2022

We will build another package for M1 when we release neuron?
Does apple Silicon applications run on intel? I don't have Apple Silicon hardware currently.

@Keith-CY
Copy link
Member Author

Keith-CY commented Oct 8, 2022

We will build another package for M1 when we release neuron? Does apple Silicon applications run on intel? I don't have Apple Silicon hardware currently.

Yes, there will be two packages for MacOS as some apps do, e.g. Or, for Macs with Apple Silicon chips, click here to download on https://zoom.us/download

The app could be packaged as a universal one but the size will be doubled because it simply includes one for intel and one for arm64. It might not be a good idea for users(but we can provide this version if possible)

I'm using M1 so I can test the package.

@alexsupa597
Copy link

We will build another package for M1 when we release neuron? Does apple Silicon applications run on intel? I don't have Apple Silicon hardware currently.

Yes, there will be two packages for MacOS as some apps do, e.g. Or, for Macs with Apple Silicon chips, click here to download on https://zoom.us/download

The app could be packaged as a universal one but the size will be doubled because it simply includes one for intel and one for arm64. It might not be a good idea for users(but we can provide this version if possible)

I'm using M1 so I can test the package.

I can test the package also.

@yanguoyu
Copy link

@JeffreyMa597 Do you have time to try to finish it?

@alexsupa597
Copy link

alexsupa597 commented Oct 13, 2022

@JeffreyMa597 Do you have time to try to finish it?

@yanguoyu sure.

@Keith-CY Keith-CY moved this from Todo to In Progress in Nervos Wallet/Explorer Oct 18, 2022
@Keith-CY
Copy link
Member Author

How is it going

@alexsupa597
Copy link

How is it going

@Keith-CY I've fixed this issue. I'll package the app on my machine and perform a local verification to verify whether the modification is successful.

I earned two problems: 1、The appleId is not found. 2、I can't sign when I commit my code. I'm trying to resolve them.

@Keith-CY
Copy link
Member Author

How is it going

@Keith-CY I've fixed this issue. I'll package the app on my machine and perform a local verification to verify whether the modification is successful.

I earned two problems: 1、The appleId is not found. 2、I can't sign when I commit my code. I'm trying to resolve them.

Cool, I would suggest proposing a draft PR first, so we can have a review. Besides, apple id is not so important to block this issue because we can verify it by CI.

For the signature of commit, we can force push the PR once it's been fixed.

@alexsupa597
Copy link

How is it going

@Keith-CY I've fixed this issue. I'll package the app on my machine and perform a local verification to verify whether the modification is successful.
I earned two problems: 1、The appleId is not found. 2、I can't sign when I commit my code. I'm trying to resolve them.

Cool, I would suggest proposing a draft PR first, so we can have a review. Besides, apple id is not so important to block this issue because we can verify it by CI.

For the signature of commit, we can force push the PR once it's been fixed.

Okay.

@Keith-CY
Copy link
Member Author

PR: nervosnetwork/neuron#2510

@alexsupa597
Copy link

PR: nervosnetwork/neuron#2515

@alexsupa597 alexsupa597 moved this from In Progress to QA in Nervos Wallet/Explorer Nov 1, 2022
@alexsupa597 alexsupa597 moved this from QA to Production in Nervos Wallet/Explorer Nov 1, 2022
@alexsupa597 alexsupa597 moved this from Production to Done in Nervos Wallet/Explorer Nov 14, 2022
Repository owner moved this from Done to Production in Nervos Wallet/Explorer Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants