Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nervos DAO rules #47

Closed
Keith-CY opened this issue Jul 25, 2022 · 6 comments
Closed

Update Nervos DAO rules #47

Keith-CY opened this issue Jul 25, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jul 25, 2022

Since Cell Mature mechanism has been updated on hardfork, the 4 epochs rule should be deprecated, and withdraw cells can be unlocked earlier.

We should check the new rule and update the workflow in neuron. Setup a draft of the new workflow first for @quake and then update the code

Ref: https://github.com/nervosnetwork/rfcs/blob/master/rfcs/0036-remove-header-deps-immature-rule/0036-remove-header-deps-immature-rule.md

@Keith-CY Keith-CY added the enhancement New feature or request label Jul 25, 2022
@Keith-CY Keith-CY self-assigned this Jul 25, 2022
@Keith-CY Keith-CY added this to the 2022/07/27 - 2022/08/03 milestone Jul 25, 2022
@Keith-CY
Copy link
Member Author

The 4 epochs requirement is only added in the UI(https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-ui/src/utils/getDAOCellStatus.ts#L65) and not included in startWithdrawFromDao and withdrawFromDao, instead, it throws an error if dao cell is immature.

So we can simply update the validation in UI and leave backend intact for this change.

@Keith-CY
Copy link
Member Author

This feature is required by community, maybe we could finish it with the current version and then merge it into the new UI version @yanguoyu

@yanguoyu
Copy link

yanguoyu commented Aug 1, 2022

This is also no need 4 epochs. https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-ui/src/utils/getDAOCellStatus.ts#L79
Nervos DAO can be withdraw right now after deposit, then can be unlock after 180 epoch.

@yanguoyu
Copy link

yanguoyu commented Aug 1, 2022

Because Nervos DAO can only unlock after 180 epoch, David account has two deposits can be unlock after 1 day, I will test unlock tomorrow.

@yanguoyu
Copy link

yanguoyu commented Aug 2, 2022

@yanguoyu yanguoyu moved this from Todo to QA in Nervos Wallet/Explorer Aug 2, 2022
@Keith-CY Keith-CY moved this from QA to Pre-release in Nervos Wallet/Explorer Aug 23, 2022
@Keith-CY Keith-CY moved this from Pre-release to QA in Nervos Wallet/Explorer Aug 23, 2022
@Cedar67
Copy link

Cedar67 commented Aug 24, 2022

nervosnetwork/neuron#2461

Verified.

@Cedar67 Cedar67 closed this as completed Aug 24, 2022
Repository owner moved this from QA to Production in Nervos Wallet/Explorer Aug 24, 2022
@Cedar67 Cedar67 moved this from Production to Pre-release in Nervos Wallet/Explorer Aug 24, 2022
@Keith-CY Keith-CY moved this from Pre-release to Production in Nervos Wallet/Explorer Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants