Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message was shown when a watching wallet is imported repeatedly. #380

Closed
Keith-CY opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Keith-CY
Copy link
Member

When a wallet is imported repeatedly, Neuron will lead users to replace the existing one.

But if the imported wallet is a watch wallet, Neuron displays an error message of "Invalid JSON file, please check your file integrity", which is misleading.

Expected to show a clearer message. e.g.

  1. Watch wallet detected in Neuron: The watch wallet has been imported before, would you replace it?
  2. Original wallet detected in Neuron: // TODO
@Keith-CY Keith-CY added the bug Something isn't working label Apr 10, 2024
@Keith-CY Keith-CY added this to Neuron Apr 10, 2024
@Danie0918 Danie0918 moved this to 🆕 New in Neuron Apr 10, 2024
@Danie0918 Danie0918 moved this from 🆕 New to 📌Planning in Neuron Apr 15, 2024
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jul 8, 2024
@Danie0918
Copy link
Contributor

Image

  • Requirement:
  1. Watch wallet detected in Neuron: Click 'Yes' to replace the existing watch wallet, click 'No' to close the popup and cancel the import.
  2. Original wallet detected in Neuron: Click 'OK' to close the popup and cancel the import.

@devchenyan
Copy link

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jul 29, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to 👀 Testing in Neuron Jul 30, 2024
@Danie0918 Danie0918 assigned silySuper and unassigned devchenyan Jul 30, 2024
@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Jul 30, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ⭐ Release List in Neuron Aug 1, 2024
@Danie0918 Danie0918 moved this from ⭐ Release List to 🚩Pre Release in Neuron Aug 1, 2024
@Danie0918 Danie0918 moved this from 🚩Pre Release to ✅ Done in Neuron Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants