Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The separation of neuron and ckb full node versions could be more clear #327

Closed
Keith-CY opened this issue Nov 23, 2023 · 4 comments
Closed

The separation of neuron and ckb full node versions could be more clear #327

Keith-CY opened this issue Nov 23, 2023 · 4 comments
Assignees
@yanguoyu
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Nov 23, 2023 •
edited
Loading

image I was confused at first glance because the column of versions and the row of versions are both close to label `Neuron`, so I had to distinguish them again. 
--------------------------------
                  CKB
--------------------------------
Neuron | 0.112 | 0.111 | 0.110 |
-------|------------------------
0.111  |
0.110  |

It can be slightly changed so only the column is aligned to label Neuron

e.g. (just for example, we may design it deliberately)

--------------------------------
       |          CKB
Neuron |------------------------
       | 0.112 | 0.111 | 0.110 |
-------|------------------------
0.111  |
0.110  |
@Keith-CY Keith-CY added the enhancement New feature or request label Nov 23, 2023
@Keith-CY Keith-CY added this to Neuron Nov 23, 2023
@Danie0918 Danie0918 moved this to 📌Planning in Neuron Nov 23, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jul 8, 2024
@Danie0918
Copy link
Contributor

Danie0918 commented Jul 9, 2024 •
edited
Loading

image

Display the Neuron title in combination with the version number.

@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 9, 2024

Image

Display the Neuron title in combination with the version number.

It looks good, but please note that the version numbers need to be sorted in descending order so the latest one can be seen first.

@Kirl70
Copy link

Kirl70 commented Jul 12, 2024

The design has been adjusted:
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=19033-39943&t=jSrokM1gUEZPpNxZ-1

Image

@github-actions github-actions bot mentioned this issue Jul 12, 2024
Merged
@yanguoyu yanguoyu self-assigned this Jul 17, 2024
@Danie0918 Danie0918 removed their assignment Jul 19, 2024
@github-actions github-actions bot mentioned this issue Jul 19, 2024
Merged
@Danie0918 Danie0918 moved this from 🎨 Designing to 🏗 In Progress in Neuron Jul 22, 2024
@yanguoyu yanguoyu mentioned this issue Jul 24, 2024
Merged
@yanguoyu
Copy link

Magickbase/websites#126

@Danie0918 Danie0918 removed the status in Neuron Jul 24, 2024
@Danie0918 Danie0918 moved this to 🔎 Code Review in Neuron Jul 24, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to ✅ Done in Neuron Jul 25, 2024
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanguoyu yanguoyu

Labels
enhancement New feature or request
Projects
Neuron
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Keith-CY @yanguoyu @poor-defined @Kirl70 @Danie0918