Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess a raw transaction so it can be signed by Neuron #314

Closed
Keith-CY opened this issue Nov 8, 2023 · 5 comments
Closed

Preprocess a raw transaction so it can be signed by Neuron #314

Keith-CY opened this issue Nov 8, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Nov 8, 2023

This issue comes from signing a transaction to upgrade a contract.


The transaction to sign is constructed by contract developer or dapp maintainer, and it's usually a raw transaction that follows data structure of https://github.com/nervosnetwork/ckb/tree/develop/rpc#type-transaction

Here is an example
raw-tx.json

But transaction to sign by Neuron requires extra information because Neuron may be running offline.

Here is an example
tx-to-sign.json

I've used the following script to transform the raw-tx into tx-to-sign

export-tx-to-sign.js.zip

It would be greatly helpful if transform could be done on Neuron Project Page

@Keith-CY Keith-CY added the enhancement New feature or request label Nov 8, 2023
@Keith-CY Keith-CY added this to Neuron Nov 8, 2023
@Danie0918 Danie0918 moved this to 🆕 New in Neuron Nov 13, 2023
@Danie0918 Danie0918 self-assigned this Nov 13, 2023
@Danie0918 Danie0918 moved this from 🆕 New to 📌Planning in Neuron Nov 13, 2023
@Danie0918 Danie0918 moved this from 📌Planning to 🎨 Designing in Neuron Jul 8, 2024
@Danie0918
Copy link
Contributor

Danie0918 commented Jul 9, 2024

preprocess_a_raw_transaction_so_it_can_be_signed_by_neuron

  • Requirement:
  1. Add Tools page.
  2. Add Raw Transaction Conversion Tool
    • Click/drag in to upload the raw transaction file.
    • Click the Process button to check and convert the raw transaction.
    • Click Download to download the converted file.

@Kirl70
Copy link

Kirl70 commented Jul 12, 2024

@Keith-CY
Copy link
Member Author

Design Draft(2-13--2-14): figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40199-56347&t=jSrokM1gUEZPpNxZ-1 image

Please enter the raw transaction data or drag in the raw transaction json file

Is it allowed for users to upload json file by clicking upload button? Generally, click to upload and drag in to upload appear together. @Danie0918

@Danie0918
Copy link
Contributor

Danie0918 commented Jul 15, 2024

Design Draft(2-13--2-14): figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=40199-56347&t=jSrokM1gUEZPpNxZ-1 image

Please enter the raw transaction data or drag in the raw transaction json file

Is it allowed for users to upload json file by clicking upload button? Generally, click to upload and drag in to upload appear together. @Danie0918

Yes, click to upload is also supported, I'll adjust the text here.

@yanguoyu
Copy link

Magickbase/websites#125

@Danie0918 Danie0918 moved this from 🏗 In Progress to 🔎 Code Review in Neuron Jul 23, 2024
@Danie0918 Danie0918 moved this from 🔎 Code Review to ✅ Done in Neuron Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants