Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nervos Dao deposit balance move to max,pop up deposit window will disappear #241

Closed
silySuper opened this issue Jul 26, 2023 · 5 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@silySuper
Copy link

In Nervos Dao deposit pop up window,it is easier to close the window when move deposit balance to max.

2023-07-26.10.32.32.mov
@silySuper silySuper added the bug Something isn't working label Jul 26, 2023
@yanguoyu
Copy link

This is cause by you have click outside the dialog.

@Kirl70
Copy link

Kirl70 commented Jul 26, 2023

I think all application pop-ups should require the user to click the close or cancel button to close the pop-up, instead of closing when clicking outside the pop-up. This will prevent users from accidentally closing the pop-up by clicking outside, which could negatively impact the user experience.
What do you think? @Danie0918

@yanguoyu
Copy link

I think all application pop-ups should require the user to click the close or cancel button to close the pop-up, instead of closing when clicking outside the pop-up. This will prevent users from accidentally closing the pop-up by clicking outside, which could negatively impact the user experience. What do you think? @Danie0918

Prevent users from accidentally closing the pop-up by clicking outside is good suggestion. And for those using a device with a keyboard, the Escape key is commonly expected to close modal dialogs as well.

@Danie0918 Danie0918 assigned devchenyan and unassigned Danie0918 Jul 26, 2023
@silySuper
Copy link
Author

Yes,now it is hard for users to drag to max,because max and outside is too closer,it is easier to click outside.

@yanguoyu yanguoyu assigned yanguoyu and unassigned devchenyan Jul 28, 2023
@yanguoyu
Copy link

It was fixed by nervosnetwork/neuron#2786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants