Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify start point to sync when a wallet is imported and synced in light-client mode #183

Closed
Keith-CY opened this issue Jun 8, 2023 · 6 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Keith-CY
Copy link
Member

Keith-CY commented Jun 8, 2023

The start point of light-client subscription is configurable, which makes it possible to synchronize from a specific block number. With the function, the following feature can be adapted to shrink the progress of synchronization in light-client mode:

  • If the wallet is imported: provide an optional prompt with the first receive address when importing a wallet, and inform the user to check the block number of the first transaction (on ckb explorer) to fill in. Neuron can be configured to start synchronization from block number of the first transaction - N(N is an internal deviation from the assumed start point)

  • If the wallet is newly generated: subscription starts from the current tip block number

@Keith-CY Keith-CY added the documentation Improvements or additions to documentation label Jun 8, 2023
@Danie0918
Copy link
Contributor

Danie0918 commented Jul 18, 2023


I designed a popup window about this requirement, but it seemed a bit complicated and uncertain considering the process of needing the user to find the blocks and fill them in themselves. Can we automatically determine the starting block and synchronize it without having to go through the user's filling and confirmation?

@Keith-CY
Copy link
Member Author

Keith-CY commented Jul 18, 2023

I designed a popup window about this requirement, but it seemed a bit complicated and uncertain considering the process of needing the user to find the blocks and fill them in themselves. Can we automatically determine the starting block and synchronize it without having to go through the user's filling and confirmation?

Light client mode only synchronizes blocks related to transactions under the current wallet has no relation to the start point of synchronization.

Can we automatically determine the starting block and synchronize it without having to go through the user's filling and confirmation?

It relies on an external service, e.g. CKB explorer, so we cannot set the start point without user's approval. And even it's approved to fetch data from CKB Explorer, the data should be confirmed by the user.

So I would suggest showing the first address and informing user to locate the earliest block where the address appeared, with a copy button and concise description + link to the tutorial on the troubleshooting page

@yanguoyu
Copy link

After the user enters the block number, we can show a link for the user that shows the block number detail to confirm.
Just like https://explorer.nervos.org/block/10487248

@Danie0918
Copy link
Contributor

[Updated]#227 (comment)

@Danie0918 Danie0918 assigned yanguoyu and unassigned Danie0918 Jul 21, 2023
@yanguoyu
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

No branches or pull requests

10 participants