Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect asset list of a specific account #759

Closed
Keith-CY opened this issue Jul 19, 2022 · 9 comments
Closed

Incorrect asset list of a specific account #759

Keith-CY opened this issue Jul 19, 2022 · 9 comments
Assignees
@Naupio @FrederLu
Labels
enhancement New feature or request
Milestone
2022/07/20 - 2022...

Comments

@Keith-CY
Copy link
Member

https://v1.gwscan.com/account/0x540c12a76fbac81b64cc119524a8b69389f0a0ae?tab=assets
This account holds 0 YOK, which should be filtered out in the list
@Keith-CY Keith-CY added the enhancement New feature or request label Jul 19, 2022
@Keith-CY Keith-CY added this to the 2022/07/13 - 2022/07/20 milestone Jul 19, 2022
@Keith-CY Keith-CY assigned Naupio and unassigned zmcNotafraid Jul 19, 2022
@Naupio Naupio moved this from Todo to In Progress in Nervos Wallet/Explorer Jul 20, 2022
@Keith-CY Keith-CY assigned Keith-CY and unassigned Naupio Jul 20, 2022
@Keith-CY
Copy link
Member Author

  1. Filtered in the front-end
  2. Filtered in the API

@Keith-CY
Copy link
Member Author

Ready in API

@Keith-CY Keith-CY moved this from In Progress to QA in Nervos Wallet/Explorer Jul 27, 2022
@Keith-CY Keith-CY assigned Naupio and FrederLu and unassigned Keith-CY Jul 27, 2022
@Naupio
Copy link
Contributor

Naupio commented Jul 27, 2022 •
edited
Loading

fix here: #745

https://github.com/Magickbase/godwoken_explorer/pull/745/files#diff-4c80ba99701cdfce4b8dc841cace402c462792957eeeedb5100d5c13655b01ebR47

@Naupio
Copy link
Contributor

Naupio commented Jul 27, 2022

image

@FrederLu
Copy link

FrederLu commented Aug 1, 2022

Image

Verified.

@Keith-CY
Copy link
Member Author

Keith-CY commented Aug 1, 2022 •
edited
Loading

https://v1.gwscan.com/account/0x540c12a76fbac81b64cc119524a8b69389f0a0ae?tab=assets

This address holds bridged YOK and native YOK of different balances

image

@Keith-CY
Copy link
Member Author

Keith-CY commented Aug 1, 2022 •
edited
Loading

v1.gwscan.com/account/0x540c12a76fbac81b64cc119524a8b69389f0a0ae?tab=assets

This address holds bridged YOK and native YOK of different balances

image

I'm going to hide bridged one because they are theoretically the same token. Difference between their value should be debugged though

@Keith-CY
Copy link
Member Author

Keith-CY commented Aug 1, 2022

v1.gwscan.com/account/0x540c12a76fbac81b64cc119524a8b69389f0a0ae?tab=assets

This address holds bridged YOK and native YOK of different balances

image

Hotfixed on mainnet, now only the native YOK is in the list
image

But the response of API should be fixed too, @Naupio @FrederLu

@Naupio
Copy link
Contributor

Naupio commented Aug 2, 2022

can fix here #805

@Keith-CY Keith-CY closed this as completed Aug 3, 2022
Repository owner moved this from QA to Production in Nervos Wallet/Explorer Aug 3, 2022
@FrederLu FrederLu moved this from Production to Done in Nervos Wallet/Explorer Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Naupio Naupio

@FrederLu FrederLu

Labels
enhancement New feature or request
Projects
No open projects
Nervos Wallet/Explorer
Archived in project
Milestone
2022/07/20 - 2022/07/27
Development

No branches or pull requests
4 participants
@Keith-CY @Naupio @zmcNotafraid @FrederLu