Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching tabs should not change the page language style. #560

Closed
FrederLu opened this issue Mar 4, 2024 · 3 comments
Closed

Switching tabs should not change the page language style. #560

FrederLu opened this issue Mar 4, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@FrederLu
Copy link

FrederLu commented Mar 4, 2024

After clicking the Depositors tab in Nervos DAO, the language of the page will be changed (from Chinese to English), which should continue the language before the switch.

2024-03-04.17.29.31.mov
@FrederLu FrederLu added the bug Something isn't working label Mar 4, 2024
@poor-defined poor-defined moved this to 🆕 New in CKB Explorer Mar 11, 2024
@Keith-CY
Copy link
Member

Filtering data in the list, e.g. https://explorer.nervos.org/zh/nervosdao changes the language too.

@Keith-CY
Copy link
Member

I've just pushed a hotfix(nervosnetwork/ckb-explorer-frontend@a82d8d7) to production to fix this issue

but my pc is out of battery, @FrederLu please do me a favor to check if all links are fixed

@FrederLu FrederLu assigned FrederLu and unassigned poor-defined Mar 11, 2024
@FrederLu FrederLu moved this from 🆕 New to 👀 Testing in CKB Explorer Mar 11, 2024
@FrederLu
Copy link
Author

I've just pushed a hotfix(nervosnetwork/ckb-explorer-frontend@a82d8d7) to production to fix this issue

but my pc is out of battery, @FrederLu please do me a favor to check if all links are fixed

This issue has been fixed after verification on Testnet and Mainnet.
Verified.

@FrederLu FrederLu moved this from 👀 Testing to ✅ Done in CKB Explorer Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants