Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests never fail #2911

Closed
rejas opened this issue Sep 17, 2022 · 3 comments
Closed

E2E tests never fail #2911

rejas opened this issue Sep 17, 2022 · 3 comments

Comments

@rejas
Copy link
Collaborator

rejas commented Sep 17, 2022

When working on my weather refactoring I noticed that the E2E tests never fail.

As can be seen after this commit to the branch d4ef2d1

the test suite should obviously fail, but the checks are all green.

Not sure yet when this bug got introduced, maybe the e2e refactoring has something to do with it? @khassel do you have an idea?
@khassel
Copy link
Collaborator

khassel commented Sep 17, 2022

do you have an idea?

not at the moment, will look into this ...

This was referenced Sep 20, 2022
Merged
Closed
@khassel
Copy link
Collaborator

khassel commented Oct 1, 2022

@rejas can this be closed? Thanks.

@rejas
Copy link
Collaborator Author

rejas commented Oct 2, 2022

Yeah, thx. Looking into the tests still since that whole done-calls are looking somehow funky...

@rejas rejas closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejas @khassel