Skip to content

Commit

Permalink
Don't stop local server instance during clean-up.
Browse files Browse the repository at this point in the history
Since `mph.start()` does not start the local server instance with the
`multi=True` option, we don't have to stop it explicitly, it will just
wind down on its own. And we don't need to add another race condition
to the exit sequence, that are plenty enough as it is.
  • Loading branch information
john-hen committed Oct 16, 2021
1 parent 8f11c0e commit d6a3e8e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions mph/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ def cleanup():
except Exception:
error = 'Error while disconnecting client at session clean-up.'
log.exception(error)
if server and server.running():
server.stop()
if jpype.isJVMStarted():
log.info('Exiting the Java virtual machine.')
sys.stdout.flush()
Expand Down

0 comments on commit d6a3e8e

Please sign in to comment.