Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React version number to profiling marks #35

Closed
2 tasks done
taneliang opened this issue Jul 9, 2020 · 1 comment · Fixed by facebook/react#19553
Closed
2 tasks done

Add React version number to profiling marks #35

taneliang opened this issue Jul 9, 2020 · 1 comment · Fixed by facebook/react#19553

Comments

@taneliang
Copy link
Member

taneliang commented Jul 9, 2020

Context

@bvaughn at #5 (comment):

Since we are actively changing the "lanes" implementation and what the semantic value of a given lane is (e.g. facebook#19287) it would be helpful for us to encode some info in our profile that lets us match this information up later.

I had been thinking about eventually encoding what the lanes ranges are, so we could display some meaningful label in the profiler, but maybe that would be a hassle and for now- we could get away with just marking the version of React the profiling data corresponds to. This would let us at least manually match the lanes up later if we wanted to dig in deeper.

TODO

  • Decide where to put the version number:
    • On profile start: ideal, but we don't yet know if/how we can detect the start of a profile
    • In all marks: called way too often and is thus wasteful
    • In commit-start: called too often
    • In render-scheduled: called too rarely, e.g. on page load
  • Add that version number
@taneliang
Copy link
Member Author

Closing, since a PR that implements this has been merged upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant