Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedicated functions to remove and add annual mean? #500

Open
mathause opened this issue Aug 19, 2024 · 1 comment
Open

dedicated functions to remove and add annual mean? #500

mathause opened this issue Aug 19, 2024 · 1 comment

Comments

@mathause
Copy link
Member

Going through the MESMER-M example notebook (#491) I found it non-obvious mesmer.stats.fit_harmonic_model also removes the annual mean from the monthly data. Now that this is no longer estimated - should we add dedicated functions to add/ remove the annual mean?

@veni-vidi-vici-dormivi
Copy link
Collaborator

I thought about this too but in the paper the term harmonic model refers to the combination of the linear regression with yearly temperature and the fourier series for the seasonal cycle. So I did not want to divide it up in the main code. We could make fit_harmonic_model call the linear regression and the fourier series separately but as we don't actually do the linear regression this doesn't make much sense.

Of course going forward we could drop the name harmonic model and just have a Fourier series around the yearly temperature but what I wrote above is the reason why its not already like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants