Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate component-wise kappa/rho degrees of freedom based on weight maps #811

Open
tsalo opened this issue Sep 24, 2021 · 0 comments
Open
Labels
effort: low Theoretically less than a day's work enhancement issues describing possible enhancements to the project impact: low Improving code/documentation cleanliness/clarity, not function priority: low issues that are not urgent TE-dependence issues related to TE dependence metrics and component selection

Comments

@tsalo
Copy link
Member

tsalo commented Sep 24, 2021

Summary

Ever since #358, we've been calculating our voxel-wise model fit F-statistics on varying numbers of echoes. When we average across voxels, we're averaging F-statistics with different DOFs. Then, we use the full n_echos for calculating a single DOF for all components' averaged F-statistics.

However, the actual degrees of freedom should vary across components. While the voxel-wise degrees of freedom will be consistent across components, the weights we use to average across voxels vary across components, which means that the ultimate average DOF will vary as well.

I very much doubt that this has a large impact on the the classification, but it seems like it would be beneficial to deal with for internal consistency.

Additional Detail

This stems from #809 (comment).

Next Steps

  1. Add a new metric that calculates the weighted average degrees of freedom of kappa and rho values based on each component's weight map and the adaptive mask.
  2. Use the new metric in getfbounds for . scipy.stats.f.ppf supports float values for the dfd parameter.
@tsalo tsalo added enhancement issues describing possible enhancements to the project priority: low issues that are not urgent TE-dependence issues related to TE dependence metrics and component selection effort: low Theoretically less than a day's work impact: low Improving code/documentation cleanliness/clarity, not function labels Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: low Theoretically less than a day's work enhancement issues describing possible enhancements to the project impact: low Improving code/documentation cleanliness/clarity, not function priority: low issues that are not urgent TE-dependence issues related to TE dependence metrics and component selection
Projects
None yet
Development

No branches or pull requests

1 participant