Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] switch from Travis CI to GitHub actions #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CI] switch from Travis CI to GitHub actions #151

wants to merge 2 commits into from

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Oct 10, 2021 •
edited
Loading

Fixes #146

Changes made in this Pull Request:

  • removed travis.yml and ci/deploy_docs.sh (not needed anymore)
  • add GH actions test and doc deployment
  • test MDAnalysis >= 1.1.1, <2 (noted in CHANGELOG)

PR Checklist

  • n/a Tests?
  • n/a Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@orbeckst
[CI] switch from Travis CI to GitHub actions
f9eb291 
- fix #146
- test MDAnalysis >= 1.0.0, <2 (noted in CHANGELOG)
@orbeckst
Copy link
Member Author

Various issues

@orbeckst orbeckst requested a review from VOD555 October 21, 2021 21:34
@orbeckst
Copy link
Member Author

We don't provide conda packages for Python 2.7 for 1.1.1. So we can either try to install the pip package for the 2.7 tests or drop 2.7 very quickly... I think it's going to be the latter.

@orbeckst orbeckst mentioned this pull request Oct 21, 2021
Open
@orbeckst orbeckst requested a review from yuxuanzhuang October 21, 2021 21:45
@orbeckst orbeckst force-pushed the travis2github branch 2 times, most recently from 30bbe88 to ca9a14d Compare October 28, 2021 22:23
@orbeckst
update Python tests
1c911c1 
- drop 2.7 (see #152)
- add 3.6
- note: 3.9 not supported in MDAnalysis 1.1.1
- update CHANGELOG
@orbeckst
Copy link
Member Author

@VOD555 can you please figure out why one RDF test is failing

pmda/test/test_rdf_s.py::test_density[False] FAILED                      [ 22%]

This needs to be fixed/figured out so that this PR can progress. Thank you!

@orbeckst orbeckst mentioned this pull request Oct 29, 2021
Open
@orbeckst
Copy link
Member Author

ping @VOD555 please have a look

@VOD555
Copy link
Collaborator

VOD555 commented Nov 11, 2021 •
edited
Loading

@orbeckst I found the density option of InterRDF_s in current MDAnalysis and pmda are different, in which density=False in MDA means density=True in pmda. It's necessary to make pmda the same as MDA. Do we need to do this change in this PR or in a new one?

@VOD555
Copy link
Collaborator

VOD555 commented Nov 11, 2021

It's corresponding to #130

@orbeckst
Copy link
Member Author

Make a new PR, please — let me know when you have it ready to review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOD555 VOD555 Awaiting requested review from VOD555

@yuxuanzhuang yuxuanzhuang Awaiting requested review from yuxuanzhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAINT: Switch from Travis to Github actions as CI provider
2 participants
@orbeckst @VOD555