Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align behaviour of waterdynamics.SurvivalProbability with other analysis methods #2524

Closed
IAlibay opened this issue Feb 10, 2020 · 0 comments · Fixed by #2525
Closed

Align behaviour of waterdynamics.SurvivalProbability with other analysis methods #2524

IAlibay opened this issue Feb 10, 2020 · 0 comments · Fixed by #2525

Comments

@IAlibay
Copy link
Member

IAlibay commented Feb 10, 2020

Description

Relates to #2505 (review)

Currently waterdynamics.SurvivalProbability:

  1. Accepts the deprecated t0, tf, and dtmax keywords in :meth:SurvivalProbability.__init__, which override the setting of start, stop, and tau_max in :meth:SurvivalProbability.run.
  2. Uses the stop (or aforementioned tf) keyword to set the final frame inclusively (rather than exclusively as done by most other analysis methods).

Describe the solution you'd like

  1. Remove the deprecated keywords, making the behaviour similar to :class:AnalysisBase methods.
  2. Make stop exclusive rather than inclusive.

Additional context
This is would complement #2505 and is a goal towards #2443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants