You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Accepts the deprecated t0, tf, and dtmax keywords in :meth:SurvivalProbability.__init__, which override the setting of start, stop, and tau_max in :meth:SurvivalProbability.run.
Uses the stop (or aforementioned tf) keyword to set the final frame inclusively (rather than exclusively as done by most other analysis methods).
Describe the solution you'd like
Remove the deprecated keywords, making the behaviour similar to :class:AnalysisBase methods.
Make stop exclusive rather than inclusive.
Additional context
This is would complement #2505 and is a goal towards #2443
The text was updated successfully, but these errors were encountered:
Description
Relates to #2505 (review)
Currently waterdynamics.SurvivalProbability:
t0
,tf
, anddtmax
keywords in :meth:SurvivalProbability.__init__
, which override the setting ofstart
,stop
, andtau_max
in :meth:SurvivalProbability.run
.stop
(or aforementionedtf
) keyword to set the final frame inclusively (rather than exclusively as done by most other analysis methods).Describe the solution you'd like
AnalysisBase
methods.stop
exclusive rather than inclusive.Additional context
This is would complement #2505 and is a goal towards #2443
The text was updated successfully, but these errors were encountered: