Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis (general) #4

Closed
5 tasks done
lilyminium opened this issue Aug 31, 2019 · 9 comments
Closed
5 tasks done

Analysis (general) #4

lilyminium opened this issue Aug 31, 2019 · 9 comments
Assignees
Labels
analysis For analysis modules

Comments

@lilyminium
Copy link
Member

lilyminium commented Aug 31, 2019

Story: As a user, I want to know how whether the analysis I have in mind is already implemented, how to use it, and how to possibly implement it myself, so that I can make contributions to science.

Acceptance criteria:

  • I know where to find a list of accepted MD formats, and the information that each format provides.
  • I know where to find whether an analysis requires particular information that may not be in every MD format (e.g. masses).
  • I know where to find a list of available analyses.
  • I know where to find a tutorial on implementing custom analysis.
  • I understand the general interface for running analysis.
@lilyminium lilyminium added the analysis For analysis modules label Aug 31, 2019
@lilyminium lilyminium self-assigned this Aug 31, 2019
@richardjgowers
Copy link
Member

discussion on the Analysis interface:

MDAnalysis/mdanalysis#719

@orbeckst
Copy link
Member

orbeckst commented Sep 5, 2019

And the current problem that the docs are missing AtomGroup methods that require masses, see MDAnalysis/mdanalysis#1845

@orbeckst
Copy link
Member

orbeckst commented Sep 5, 2019

I would also add: the docs point to the primary literature and I know how to read about the implemented method.

Ultimately I would also need to know how to cite a certain existing analysis. The duecredit functionality might be worthwhile pointing out.

@orbeckst
Copy link
Member

orbeckst commented Sep 5, 2019

IMO, this issue seems to be the place to lead towards AnalysisBase, and not so much #7

@lilyminium
Copy link
Member Author

@richardjgowers Are there any plans to refactor existing modules e.g. helanal and gnm to fit the Bauhaus style?

@orbeckst MDAnalysis gives my coarse-grained beads masses of 0 when it can't guess them from a GRO file -- is this behaviour common to all formats, or is the mass attribute simply missing from some of them?

@orbeckst
Copy link
Member

orbeckst commented Sep 9, 2019 via email

@richardjgowers
Copy link
Member

richardjgowers commented Dec 30, 2019

I'm not sure there's a rule re: guessing masses. 0 is a good compromise for failure (though maybe np.NaN might be better?) because it's obviously not right. Sentinel values like 1 could seem correct?

@lilyminium
Copy link
Member Author

Oops, sorry for the edit, I’m on my phone and thought I was replying — reverted back.

I'm not sure there's a rule re: guessing masses. 0 is a good compromise for failure (though maybe np.NaN might be better?) because it's obviously not right. Sentinel values like 1 could seem correct?

np.NaN strikes me as better because I suppose virtual sites or dummy atoms would have a mass of 0. Also, I think it might fail in mass-related calculations, which is probably desirable?

@lilyminium lilyminium mentioned this issue Feb 7, 2020
48 tasks
@orbeckst
Copy link
Member

The user guide allows people to find analysis tools (and now we also have mdakits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis For analysis modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants