-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analysis (general) #4
Comments
discussion on the Analysis interface: |
And the current problem that the docs are missing AtomGroup methods that require masses, see MDAnalysis/mdanalysis#1845 |
I would also add: the docs point to the primary literature and I know how to read about the implemented method. Ultimately I would also need to know how to cite a certain existing analysis. The duecredit functionality might be worthwhile pointing out. |
IMO, this issue seems to be the place to lead towards |
@richardjgowers Are there any plans to refactor existing modules e.g. @orbeckst MDAnalysis gives my coarse-grained beads masses of 0 when it can't guess them from a GRO file -- is this behaviour common to all formats, or is the |
On Sep 9, 2019, at 7:46 AM, Lily Wang ***@***.***> wrote:
@richardjgowers <https://github.com/richardjgowers> Are there any plans to refactor existing modules e.g. helanal and gnm to fit the Bauhaus style?
We would love to have it refactor if anyone would spare the time. It’s open source...
@orbeckst <https://github.com/orbeckst> MDAnalysis gives my coarse-grained beads masses of 0 when it can't guess them from a GRO file -- is this behaviour common to all formats, or is the mass attribute simply missing from some of them?
Good question – I don’t know. @richardjgowers? Would be good to have written down how/when we do guessing.
|
I'm not sure there's a rule re: guessing masses. 0 is a good compromise for failure (though maybe np.NaN might be better?) because it's obviously not right. Sentinel values like 1 could seem correct? |
Oops, sorry for the edit, I’m on my phone and thought I was replying — reverted back.
np.NaN strikes me as better because I suppose virtual sites or dummy atoms would have a mass of 0. Also, I think it might fail in mass-related calculations, which is probably desirable? |
The user guide allows people to find analysis tools (and now we also have mdakits). |
Story: As a user, I want to know how whether the analysis I have in mind is already implemented, how to use it, and how to possibly implement it myself, so that I can make contributions to science.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: