Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video rotation fills the entire disk space #766

Closed
pchampio opened this issue Oct 31, 2020 · 5 comments
Closed

Video rotation fills the entire disk space #766

pchampio opened this issue Oct 31, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@pchampio
Copy link
Contributor

Video rotation fills the entire disk space

Steps to reproduce the issue

  1. On a uploaded video, click the rotate button.
  2. Don't do it again.

I have done it once, I don't want to try it again, but I thinks this was the issue.

Output of the diagnostics [REQUIRED]




    Diagnostics
    -------
    Info: Latest version of PHP is 7.4
    Warning: You may experience problems when uploading a photo of large size. Take a look in the FAQ for details.
    Warning: Dropbox import not working. dropbox_key is empty.
    Warning: lossless_optimization set to 1 but svgo not found!




    System Information
    --------------
    Lychee Version (git):            master (77ad51e) - Data not in Cache
    DB Version:                      4.0.7
    
    composer install:                --no-dev
    APP_ENV:                         production
    APP_DEBUG:                       false
    
    System:                          Linux
    PHP Version:                     7.3
    Max uploaded file size:          20M
    Max post size:                   100M
    PostgreSQL Version:              PostgreSQL 10.13 on x86_64-pc-linux-musl, compiled by gcc (Alpine 9.3.0) 9.3.0, 64-bit
    
    Imagick:                         1
    Imagick Active:                  1
    Imagick Version:                 1690
    GD Version:                      2.2.5

    
    Lychee total space:              33.81 MB
    Upload folder space:             8.00 B
    System total space:              45.61 GB
    System free space:               12.85 GB (28%)

    
    Lychee total space:              33.81 MB
    Upload folder space:             8.00 B
    System total space:              45.61 GB
    System free space:               12.85 GB (28%)




    Config Information
    --------------
    version:                         040007
    check_for_updates:               0
    sorting_Photos_col:              takestamp
    sorting_Photos_order:            ASC
    sorting_Albums_col:              min_takestamp
    sorting_Albums_order:            DESC
    imagick:                         1
    skip_duplicates:                 0
    small_max_width:                 0
    small_max_height:                360
    medium_max_width:                1920
    medium_max_height:               1080
    lang:                            en
    layout:                          1
    image_overlay:                   1
    image_overlay_type:              exif
    default_license:                 CC-BY-SA-4.0
    compression_quality:             90
    full_photo:                      1
    delete_imported:                 0
    Mod_Frame:                       1
    Mod_Frame_refresh:               30
    thumb_2x:                        1
    small_2x:                        1
    medium_2x:                       1
    landing_page_enable:             0
    landing_owner:                   Pierre C
    landing_title:                   Pierre C
    landing_subtitle:                
    landing_facebook:                
    landing_flickr:                  
    landing_twitter:                 
    landing_instagram:               
    landing_youtube:                 
    landing_background:              dist/cat.jpg
    site_title:                      Albums de Pierre
    site_copyright_enable:           0
    site_copyright_begin:            2019
    site_copyright_end:              2019
    additional_footer_text:          
    display_social_in_gallery:       0
    public_search:                   1
    SL_enable:                       0
    SL_for_admin:                    0
    public_recent:                   0
    recent_age:                      4
    public_starred:                  0
    downloadable:                    1
    photos_wraparound:               0
    map_display:                     0
    zip64:                           1
    map_display_public:              0
    map_provider:                    Wikimedia
    force_32bit_ids:                 0
    map_include_subalbums:           0
    update_check_every_days:         3
    has_exiftool:                    1
    share_button_visible:            1
    import_via_symlink:              0
    has_ffmpeg:                      1
    location_decoding:               0
    location_decoding_timeout:       30
    location_show:                   1
    location_show_public:            0
    rss_enable:                      0
    rss_recent_days:                 7
    rss_max_items:                   100
    prefer_available_xmp_metadata:   0
    editor_enabled:                  1
    lossless_optimization:           1
    swipe_tolerance_x:               150
    swipe_tolerance_y:               250
    local_takestamp_video_formats:   .avi|.mov
    log_max_num_line:                1000
@ildyria
Copy link
Member

ildyria commented Oct 31, 2020

Outch. I thought this would be disabled for video.

@ildyria ildyria added the bug Something isn't working label Oct 31, 2020
@ildyria
Copy link
Member

ildyria commented Nov 7, 2020

Could you check if #777 solve this issue ?

@pchampio
Copy link
Contributor Author

pchampio commented Nov 7, 2020

In the console I get:

{
  "description": null,
  "params": {
    "photoID": "XXXXXXXXX",
    "direction": -1
  },
  "response": false
}

In the log I get:
2020-11-07 17:24:42 -- error -- App\Http\Controllers\PhotoEditorController::rotate -- 62 -- Trying to rotate a video

@ildyria
Copy link
Member

ildyria commented Nov 7, 2020

So I guess it solves it now. :D

@ildyria ildyria closed this as completed Nov 7, 2020
@kamil4
Copy link
Contributor

kamil4 commented Nov 9, 2020

Well, arguably we should also fix the front end so that it doesn't display those buttons for video files, shouldn't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants