Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer linkable. #529

Closed
fotocreativo opened this issue May 3, 2020 · 17 comments · Fixed by #530
Closed

Footer linkable. #529

fotocreativo opened this issue May 3, 2020 · 17 comments · Fixed by #530

Comments

@fotocreativo
Copy link

I am trying to place the link button „HOSTED WITH LYCHEE“. Would ist be possible in you could make the footer linkable in the Settings? In would be really friendly of you could insert that. So I would have a possibility to easily instert an imprint. Thanks a lot.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

Hummm I thought I fixed that.

@fotocreativo
Copy link
Author

That would be great.i just can‘t get it together...:-( Or do you have a guess? Greetings Mario.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

As soon as the PR is merged you should be able to use html code in the advanced setting additional_footer_text.

@fotocreativo
Copy link
Author

Thanks, i‘ll try ist now. Thanks a lot.

@fotocreativo
Copy link
Author

Yes show,but not clickable for a link.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

@fotocreativo
Copy link
Author

I need an „imprint“ (Impressum) in Germany. Without this you will get a Warnung from lawyers in Germany.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

I know. This is exactly the reason why we added this.
See here: LycheeOrg/Lychee-v3#5

@fotocreativo
Copy link
Author

Thanks for your help.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

Was fixed with: #257

But the update of the laravel framework from version 6 to version 7 changed the syntax for allowed html in blade template from {{ $var }} to {!! $var !!}.

@fotocreativo
Copy link
Author

Now I'm a little confused as to what's next. Will this be installed via an update? Or does it only need to download certain parts of it?

@fotocreativo
Copy link
Author

The first idea was to create an own html page and link it, which is not that difficult. Since it is possible to enter a footer text, I thought it might be the easiest way. But I've been sitting there all morning trying to solve it differently, but without success.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

So if you have access to the database, you can actually create pages directly in Lychee (via SQL request), it supports markdown.


That is how I created: https://photography.viguier.nl/about

@ildyria
Copy link
Member

ildyria commented May 3, 2020

@fotocreativo if you do a git pull in your lychee installations, this should be fixed.

@fotocreativo
Copy link
Author

fotocreativo commented May 3, 2020

/git (and subdirectories) are not executable, check the permission. Lychee is provided by my provider, but I also use fileZilla. Which flags do I have to set?
Which folders do I have to give write permission (777)? Your side is great! Just what I had in mind.

@ildyria
Copy link
Member

ildyria commented May 3, 2020

Lychee is provided by my provider

Suprising.

Then I assume you are not using the master branch but the release channel ? If so sadly you will have to wait for the version 4.0.4

The other approach is to git clone the repository locally and do make dist. This will generate an archive containing the release files.

As for the folder requiring write access: storage, dist and public (and subfolders). Though I would not recommend 777, but change the group ownership and give the said group read-write-execute.

If it says git is not executable, it means that you need to also give write access to the .git (and subfolders) at the root of the repository.

@fotocreativo
Copy link
Author

I have written to the provider, thank you very much for your help!

Greetings
www.FotoCreativo.de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants