Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Permit sharing of subalbums at creation #292

Open
OmniTroid opened this issue Jun 19, 2019 · 9 comments
Open

[Enhancement] Permit sharing of subalbums at creation #292

OmniTroid opened this issue Jun 19, 2019 · 9 comments
Labels
enhancement New feature or request

Comments

@OmniTroid
Copy link

Say I've shared album X with user A. Now, when I create a subalbum in X, let's call it Y. However, it will not be shared with A by default, it has to be manually shared with user A. This goes for all subalbums under X..

Now, it would be a massive help if every new subalbum under X would automatically be shared with everyone who can access X (Y inherits access rights of X, if you will).

Does this seem like a reasonable request?

@ildyria ildyria added the enhancement New feature or request label Jun 19, 2019
@ildyria
Copy link
Member

ildyria commented Jun 19, 2019

While I see your point, I'm actually using it the opposite way to have more granularity on what my visitors can and cannot see. What could be done however is when creating a subalbum to add the option whether you want to replicate the sharing parameters of the parent: if public -> public.
Though if the parent album is shared but not visible the the sub album would be shared but visible (inside the parent obviously).

Now, it would be a massive help if every new subalbum under X would automatically be shared with everyone who can access X (Y inherits access rights of X, if you will).

I am totally against this (the automatically).

@ildyria ildyria changed the title [Enhancement] Permit automatic sharing of subalbums [Enhancement] Permit sharing of subalbums at creation Jun 19, 2019
@ildyria
Copy link
Member

ildyria commented Jun 19, 2019

I edited your title to reflect a more desirable behaviour. Note that the default setting [not share|share] could be set in the config.

@kamil4
Copy link
Contributor

kamil4 commented Jun 19, 2019

What could be done however is when creating a subalbum to add the option whether you want to replicate the sharing parameters of the parent: if public -> public.

I think ideally it could be a tri-state: yes/no/ask.

Though if the parent album is shared but not visible the the sub album would be shared but visible (inside the parent obviously).

Same with the password protection. So the only property a new subalbum should inherit is public, and probably also downloadable. And the v4-style sharing with individual users.

@matthijskooijman
Copy link

This is related to #12 (which discusses the reverse - whether to share children when a parent is shared).

@ma-tt
Copy link

ma-tt commented Sep 13, 2020

+1

Let's say I create a folder called "photos of bob" and inside that album I have two sub albums called "bob at the beach" and "bob at home". Now, I share the parent album called "photos of bob" and view that link. Currently I get a blank page. Absolutely nothing.

Surely, the default behavior would be to see the content of the folder that was just shared. If people want more options, customization, or to be asked each time, that is all awesome and welcomed. Everyone loves options. But the current way it works is not at all desirable or intuitive.

@verymilan
Copy link

+1 for this – i was just sharing an album with contents grouped into sub-albums and then realized that i have shared an empty album.. that even remains empty when sharing a subalbum.

@ildyria
Copy link
Member

ildyria commented Dec 28, 2023

There is now a global setting for that:

default_album_protection

Default protection for newly created albums. 1 = private, 2 = public, 3 = inherit from parent

@ildyria ildyria closed this as completed Dec 28, 2023
@blaine07
Copy link

+1

Let's say I create a folder called "photos of bob" and inside that album I have two sub albums called "bob at the beach" and "bob at home". Now, I share the parent album called "photos of bob" and view that link. Currently I get a blank page. Absolutely nothing.

Surely, the default behavior would be to see the content of the folder that was just shared. If people want more options, customization, or to be asked each time, that is all awesome and welcomed. Everyone loves options. But the current way it works is not at all desirable or intuitive.

Here to say - I wish it did this too. I shared a album and I expected this entire time all sub albums as I created them would be shared. Now I am sharing several sub albums looking like a dufus. Can this be re-visitied?

@ildyria
Copy link
Member

ildyria commented Apr 17, 2024

Can this be re-visitied?

@blaine07
Would a button "propagate current permission" fix your issues ?
It would be red, and would erase all the permissions from children folders and replace them with current album permission.

@ildyria ildyria reopened this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants