Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] create tag albums in a album #1567

Open
pchampio opened this issue Oct 24, 2022 · 2 comments
Open

[Enhancement] create tag albums in a album #1567

pchampio opened this issue Oct 24, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@pchampio
Copy link
Contributor

pchampio commented Oct 24, 2022

Before lychee v4.6.0 a tag album could be added (moved actually) to any album.
This was super useful to create restricted version of an album by only tagging the images and keeping the album structure nice and organized.
Here is an example:

/
├─ vacances mer/
│  │  ├─ photo_1_real (tag fav_vm)
│  │  ├─ photo_2_real
│  │  ├─ photo_3_real
│  │  ├─ [....]
│  ├─ favorites/ (tag fav_vm)
│  │  ├─ photo_1_tag
├─ vacances soleil/
│  │  ├─ photo_1_real (tag fav_vs)
│  │  ├─ photo_2_real
│  │  ├─ photo_3_real (tag fav_vs)
│  │  ├─ [....]
│  ├─ favorites/ (tag fav_vs)
│  │  ├─ photo_1_tag
│  │  ├─ photo_3_tag

The lookup of tagged images works globally (not per albums), it is up to the user to set different 'fav' identifier like in the example.

@kamil4
Copy link
Contributor

kamil4 commented Oct 25, 2022

Yeah, I see what you were doing there, but this was never meant to be a supported scenario. Tag albums as currently implemented were meant to reside at the top level only and being able to move them to another album was basically a bug, which we've fixed now.

There is of course a larger conversation to be had about how best to support a scenario like the one you outlined above; in fact, we've had at least some of that conversation already, though without reaching any conclusions (or at least without anybody implementing any replacement so far).

Let's make sure though that we fully understand how you want this to work. You would like to keep all the photos from a particular event in a single album, but then you would like to make a subset of these photos public, correct? And you want to avoid having the public vs non-public photos in separate albums (which is how this could be solved now)? Or are all the photos (and their containing album) public and you simply want to have an additional grouping of favorite ones (and you don't want to simply use the current "Copy" functionality, presumably because the metadata can then get of sync between the copies?).

@pchampio
Copy link
Contributor Author

pchampio commented Oct 25, 2022

You would like to keep all the photos from a particular event in a single album, but then you would like to make a subset of these

yes.

subset of these photos public, correct?

yes, but In my case, the 'non-favorite' album is also public. (we will come to this later).

And you want to avoid having the public vs non-public photos in separate albums (which is how this could be solved now)?

Everything is public in my case.

[.....] (which is how this could be solved now) ?
Or are all the photos (and their containing album) public and you simply want to have an additional grouping of favorite ones (and you don't want to simply use the current "Copy" functionality, presumably because the metadata can then get of sync between the copies?)

Actually, even if the tag album is shared, it cannot 'unlock' the photos it contains due to this ownership issue.

I have missed the "Copy" functionality. I should be using it!
It solves the ownership issue, and I understand the use case now.

I quite like tag albums. As you said, the metadata can then sync between the copies and keeps the database nicely organized.
But it is just not the right tool for what I want to do. And I also don't see how to solve the ownership issue without having to rely on a form of copy.

Thanks for your comment and good questions that made me realize the tag album limitation and how 'Copy' is not that bad, actually ❤️ !
You can close this issue.

@qwerty287 qwerty287 added the enhancement New feature or request label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants