Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow identical lines in import #522

Closed
jzohrab opened this issue Nov 27, 2024 · 2 comments
Closed

Allow identical lines in import #522

jzohrab opened this issue Nov 27, 2024 · 2 comments
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Nov 27, 2024

Currently the term import fails if the same term is listed twice, e.g. in tests/features/term_import:

    Scenario: Duplicate term throws
        Given import file:
            language,term
            Spanish,gato
            Spanish,gato
        Then import should fail with message:
            Duplicate terms in import: Spanish: gato

Really, this should only be a problem if there is inconsistent data. e.g, this is bad:

    Scenario: Duplicate term throws
        Given import file:
            language,term,translation
            Spanish,gato,cat
            Spanish,gato,kitty
        Then import should fail with message:
            Duplicate terms in import: Spanish: gato

but this should work:

    Scenario: identical lines ok
        Given import file:
            language,term
            Spanish,gato,cat
            Spanish,gato,cat
        Then import should succeed with 1 term imported
@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Nov 27, 2024
@jzohrab jzohrab added this to Lute-v3 Nov 27, 2024
@jzohrab jzohrab moved this to Done in Lute-v3 Nov 27, 2024
@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Nov 27, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Nov 27, 2024

fixed in develop with test case.

@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 13, 2024

Released in 3.6.1.

@jzohrab jzohrab closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Archived in project
Development

No branches or pull requests

1 participant