Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images propagate up to parent when child is updated #496

Closed
bwkimmel opened this issue Oct 17, 2024 · 3 comments
Closed

Images propagate up to parent when child is updated #496

bwkimmel opened this issue Oct 17, 2024 · 3 comments
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks

Comments

@bwkimmel
Copy link
Contributor

Description

When updating anything about a child term and saving those changes, if the child term has an image and the parent does not, the child term's image gets applied to the parent.

To Reproduce

Steps to reproduce the behavior, e.g.:

  • Create a term "parent"
  • Create a child term "child" with "parent" as it's parent.
  • Add an image to the child term (this will get applied to both terms when saved, which is arguably not the wrong thing to do here).
  • Navigate to the "parent" and delete the image.
  • Navigate to the "child" term from there click on the link to "parent" (which will cause child to be saved before navigating away).
  • Parent now has the child term's image reapplied.

Screenshots

If it will be helpful, add screenshots.

Extra software info, if not already included in the Description:

  • OS (e.g., iOS, windows): Arch Linux under WSL2 (Windows 11)
  • Browser (e.g., chrome, safari): Brave
  • How you've installed Lute (Docker, python, source): Source
  • Version: 3.5.6
@jzohrab jzohrab added this to Lute-v3 Oct 21, 2024
@jzohrab jzohrab added the tweak Adjustment to the code -- not a new feature, just minor mods/tweaks label Oct 21, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Oct 21, 2024

Thanks @bwkimmel -- I'm assuming that this issue is for exactly the scenario above; i.e. when changing an existing child, the existing parent shouldn't get the image or translation.

If creating a new child term, the parent will continue to get the image and translation if needed, because the user (me) has likely just been lazy when creating that parent at some point in the past.

@jzohrab
Copy link
Collaborator

jzohrab commented Oct 23, 2024

Change made in develop branch, in commit d045ad2. With this, editing an existing child doesn't also propagate the translation and image data to the parent, even if that data is missing in the parent.

@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Oct 23, 2024
@jzohrab jzohrab moved this to Done in Lute-v3 Oct 23, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Oct 28, 2024

Launched in 3.5.8.

@jzohrab jzohrab closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched. tweak Adjustment to the code -- not a new feature, just minor mods/tweaks
Projects
Archived in project
Development

No branches or pull requests

2 participants