Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocabulary "mining" mode that automatically selects the next unknown word #434

Closed
yue-dongchen opened this issue May 25, 2024 · 6 comments
Closed
Assignees
Labels
fixed Fixed in develop or master, to be launched. question Further information is requested

Comments

@yue-dongchen
Copy link
Contributor

As discussed on Discord

Ad hoc point: I don't know if the LingQ implementation that Xolog refers to ("all of the new words in a list") displays surrounding context on that page. The surround context would be quite important, regardless of whether it's realised as a distinct page.

Discord chat log

yue_dongchen:
Particularly for speeches, I always jump through the unknown words before listening to the audio. My proposal is a mode in which the next word would be selected upon saving a term. Does anyone think this would be helpful?

PS No GitHub issue yet. I will create one if there is a prospect of it being implemented

Xolog9017
ah yeah that would actually be really nice. I would use it before every comprehensible input video going forward. Because it will make it easy to look for new words in videos and conveniently get them assigned to 1 straight away
Or even better, jz, if you decide to go down this path, you can take some inspiration from LingQ's page where they show all of the new words in a list. Then you don't have to write the code for making the selected word jump to the next unknown word

jzohrab
Thanks both 🙃

@jzohrab
Copy link
Collaborator

jzohrab commented May 28, 2024

Thanks for the issue -- some misc notes:

  • I used to have a "shift + arrow = next unknown word" or something like it but it was confusing, so I got rid of it. :-) I never got enough value out of this idea, and as the words are already highlighted in blue, it's just a click to the next one.
  • Re showing all the new words in a list -- that might be possible, but without context words start to lose meaning. Maybe that's ok for some people though, depending on learning style. For long texts/new users, this list would rapidly get out of control. Perhaps just show them for the current page ?

Lute currently does have a "toggle highlights" thing, where all of the highlighting is hidden. I wonder if it would suffice to have some variation of this: "toggle highlights except for unknown words" -- that way the new stuff would be highlighted, but the rest of the page would be white/background color. The wording is clumsy but maybe the idea is ok. Or maybe the "toggle highlights" thing could do "cycle highlights" -- start as-is, then toggle all off, then toggle all except for the unknown words off. Of the ideas given, this feels like the smallest amount of work (though it might still be tough, depending on how I wrote that toggle stuff in the past :-) )

@jzohrab jzohrab added this to Lute-v3 May 28, 2024
@jzohrab jzohrab added the question Further information is requested label May 28, 2024
@yue-dongchen
Copy link
Contributor Author

yue-dongchen commented Jun 4, 2024

Thanks for the reply. I look to submit a PR leveraging the keys "j" and "l" for respectively backwarding and forwording to adjacent unknown words. They're on the home row for QWERTY-like layouts. Concededly not ideal for I guess more geeky users on alternate layouts.

Update 06/06/2024: I don't have such basic programming skills as of now, and I also am working towards my secondary school exams which will occur later this year. It will be a couple of months before I get to this.

@jzohrab
Copy link
Collaborator

jzohrab commented Jun 9, 2024

Good luck on your exams!

@jzohrab
Copy link
Collaborator

jzohrab commented Oct 20, 2024

Following up: Lute will soon have customizable shortcuts per #141 , so this could be added as a new shortcut.

Another note: when I originally had this, I found it hard to use. My eyes couldn't figure out where I was in the page, so it was a bit weird. :-)

@jzohrab
Copy link
Collaborator

jzohrab commented Oct 28, 2024

Hi @yue-dongchen - I found that I wanted something like this in some reading as well, so I'm adding new shortcuts to support moving to the prev/next unknown word. I have those mapped to "shift-arrowleft" and "shift-arrowright" on my mac, it works well. I also added a small flash for when it moves to the new word, to help me find it.

I'm adding this to the develop branch and will release it soon. cheers!

@jzohrab jzohrab moved this to In Progress in Lute-v3 Oct 28, 2024
@jzohrab jzohrab moved this from In Progress to Done in Lute-v3 Oct 28, 2024
@jzohrab jzohrab added the fixed Fixed in develop or master, to be launched. label Oct 28, 2024
@jzohrab
Copy link
Collaborator

jzohrab commented Oct 28, 2024

Launched in 3.5.8.

@jzohrab jzohrab closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Fixed in develop or master, to be launched. question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

2 participants