Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how Lute loads demo data #274

Closed
jzohrab opened this issue Feb 21, 2024 · 2 comments
Closed

Change how Lute loads demo data #274

jzohrab opened this issue Feb 21, 2024 · 2 comments
Labels
code-improvement Make code/structure better duplicate This issue or pull request already exists move-language-data move language data to separate repository

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Feb 21, 2024

Summary

For new users, Lute should only load language data when the user requests it.

Current issue

Lute currently loads all languages and demos in lute/db/demo into the database, and as part of the release process, those lanuages and demo stories are all loaded into the baseline database, which is also committed to the repo. This loading of all of the data creates a lot of code repo thrash, eg when a new field is added to some tables (languages, books, texts, etc).

In addition, this creates problems when the demo comes pre-loaded with Japanese, but it needs to be hidden on startup ...

A few people are creating sensible defaults for all languages and stories -- these could all be available within the Lute package and then users could install it.

Changes envisioned

  • change the release process to only include English and the Tutorial
  • optionally include some obvious easy things like French, Spanish
  • add screen for users to list and load other available languages, and potentially stories
  • handle the toggle of "demo mode" somehow ... not sure what's involved just yet.
@jzohrab jzohrab added enhancement code-improvement Make code/structure better labels Feb 21, 2024
@jzohrab jzohrab added this to Lute-v3 Feb 21, 2024
@jzohrab jzohrab added this to Lute-v3 Apr 1, 2024
@jzohrab jzohrab added the move-language-data move language data to separate repository label Apr 4, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 10, 2024

Being handled in #534 .

@jzohrab jzohrab closed this as completed Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Done in Lute-v3 Dec 10, 2024
@github-project-automation github-project-automation bot moved this to Done in Lute-v3 Dec 10, 2024
@jzohrab jzohrab added the duplicate This issue or pull request already exists label Dec 10, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Dec 13, 2024

Released in 3.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-improvement Make code/structure better duplicate This issue or pull request already exists move-language-data move language data to separate repository
Projects
Archived in project
Development

No branches or pull requests

1 participant