Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create tag when something else pulls focus from the input text box #214

Closed
jzohrab opened this issue Feb 8, 2024 · 4 comments
Closed

Comments

@jzohrab
Copy link
Collaborator

jzohrab commented Feb 8, 2024

From discord:

Also, with the new "backspace to edit parent term" feature in the reader, there is now no way to delete a mistyped parent term without using the mouse to click the small x. Might I suggest adding the ability to shift+backspace or ctrl/cmd+backspace to delete the parent instead of going into edit mode? I think both features are useful but with scottish gaelic, the dictionary I use frequently captures focus, meaning that if I'm in the middle of typing a parent, it will remove focus from the text box, resulting in a mis-typed parent term that I have to delete

@jzohrab jzohrab added this to Lute-v3 Feb 8, 2024
@jzohrab jzohrab moved this to Todo in Lute-v3 Feb 8, 2024
@jzohrab jzohrab removed the status in Lute-v3 Feb 8, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Feb 9, 2024

The mistyped parent can be deleted by backspacing/deleting all the characters. Workaround! :-)

@jzohrab jzohrab moved this to In Progress in Lute-v3 Feb 10, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Feb 10, 2024

#216 (pasting parent tag) fixed the code so that pasting stuff into the tags shows the parent list dropdown. With that change, it's really not necessary (or useful) to edit the parent tags anymore, so I changed backspace to once again delete the tags. Code and UX thrash for the win!

This ticket seems to have more to do with the parent tag thing losing focus, and creating a tag. E.g., if I'm in the parent tag and type "th" and see a suggestion list (the/thing/that/this), and then the dictionary pulls focus, a "th" tag gets created.

I've changed this so that you now have to hit Enter to make the tag. e.g., if I'm typing "th":

Image

and something else pulls focus, what I typed remains:

Image

and I have to go back and finish typing and select what I wanted. Not perfect, but I think better.

@jzohrab
Copy link
Collaborator Author

jzohrab commented Feb 10, 2024

fixed in develop, will be in next launch.

@jzohrab jzohrab moved this from In Progress to Done in Lute-v3 Feb 10, 2024
@jzohrab jzohrab changed the title "backspace = edit" for parent term makes delete a bit harder Don't create tag when something else pulls focus from the input text box Feb 10, 2024
@jzohrab
Copy link
Collaborator Author

jzohrab commented Feb 11, 2024

Fixed in 3.1.4.

@jzohrab jzohrab closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant