feat: Cache the JSON documentation of path dependencies #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeMathWalker
force-pushed
the
rustdoc-cache-hits
branch
from
87085a7
to
622f0be
Compare
|
/ok-to-test sha=622f0be |
LukeMathWalker
force-pushed
the
rustdoc-cache-hits
branch
from
622f0be
to
a7bb5bd
Compare
|
/ok-to-test sha=a7bb5bd |
LukeMathWalker
force-pushed
the
rustdoc-cache-hits
branch
from
459b9de
to
4ab1e70
Compare
|
/ok-to-test sha=4ab1e70 |
LukeMathWalker
force-pushed
the
rustdoc-cache-hits
branch
from
4ab1e70
to
71dc4ab
Compare
|
/ok-to-test sha=71dc4ab |
LukeMathWalker
force-pushed
the
rustdoc-cache-hits
branch
from
71dc4ab
to
f18c989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We compute the hash of their contents to avoid serving stale data.
It should significantly speed up the execution of our UI tests since each test is currently re-computing the JSON docs for
pavex, which comes in as a path dependency. This should save us ~100 unnecessary invocations torustdoc.