Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date format error in get_user_name_change #72

Merged
merged 3 commits into from
Mar 26, 2023

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Mar 26, 2023

Description

This PR fixes an issue in the get_user_name_change function.

Fixes #71

Type of change

  • 🪳 Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5ee8f92) 79.02% compared to head (3b97d2d) 79.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files          25       25           
  Lines         820      820           
  Branches       79       79           
=======================================
  Hits          648      648           
  Misses        148      148           
  Partials       24       24           
Impacted Files Coverage Δ
mojang/api/session.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucino772 Lucino772 merged commit 804ce2d into main Mar 26, 2023
@Lucino772 Lucino772 deleted the fix/date-format-error branch March 26, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError when getting MicrosoftAuthenticatedUser
1 participant