Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed 404 error for get_uuid & get_username #59

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

Lucino772
Copy link
Owner

@Lucino772 Lucino772 commented Feb 4, 2023

Description

This PR fixes some some issues due to a change in the return status code for the get_uuid and get_username API. Instead of a 204 response, when a value does not exists a 404 response is returned.

Type of change

  • 🪳 Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Base: 67.92% // Head: 67.96% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (17872a8) compared to base (60fc8b4).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 17872a8 differs from pull request most recent head 90c48b1. Consider uploading reports for the commit 90c48b1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   67.92%   67.96%   +0.03%     
==========================================
  Files          27       27              
  Lines         901      902       +1     
  Branches       83       83              
==========================================
+ Hits          612      613       +1     
  Misses        269      269              
  Partials       20       20              
Impacted Files Coverage Δ
mojang/api/auth/models.py 41.13% <ø> (ø)
mojang/api/models.py 84.25% <ø> (ø)
mojang/api/base.py 98.21% <100.00%> (ø)
mojang/api/session.py 98.79% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Lucino772 Lucino772 merged commit d8b9cf3 into main Feb 4, 2023
@Lucino772 Lucino772 deleted the hotfix/status-code-404 branch February 4, 2023 11:26
Lucino772 added a commit that referenced this pull request Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant