From fbddc6d153dad5510051015712308bc356c84238 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 15:21:19 +0800 Subject: [PATCH 1/9] chore: fix analysis issue on flutter 3.3.0 --- frontend/app_flowy/packages/appflowy_editor/README.md | 2 +- .../app_flowy/packages/appflowy_editor/lib/appflowy_editor.dart | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/app_flowy/packages/appflowy_editor/README.md b/frontend/app_flowy/packages/appflowy_editor/README.md index 21df5f247a89..1ccbf558787f 100644 --- a/frontend/app_flowy/packages/appflowy_editor/README.md +++ b/frontend/app_flowy/packages/appflowy_editor/README.md @@ -21,7 +21,7 @@ and the Flutter guide for

- +
## Key Features diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/appflowy_editor.dart b/frontend/app_flowy/packages/appflowy_editor/lib/appflowy_editor.dart index 12b3a2925234..a77f3fe7eb46 100644 --- a/frontend/app_flowy/packages/appflowy_editor/lib/appflowy_editor.dart +++ b/frontend/app_flowy/packages/appflowy_editor/lib/appflowy_editor.dart @@ -20,5 +20,6 @@ export 'src/service/render_plugin_service.dart'; export 'src/service/service.dart'; export 'src/service/selection_service.dart'; export 'src/service/scroll_service.dart'; +export 'src/service/toolbar_service.dart'; export 'src/service/keyboard_service.dart'; export 'src/service/input_service.dart'; From d1a061226b88d0335ef3d8db45e29df33eaa6368 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 15:56:15 +0800 Subject: [PATCH 2/9] chore: add codecov github action --- .github/workflows/flowy_editor_test.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 1459a475180c..4e14efa1a839 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -4,6 +4,7 @@ on: push: branches: - "main" + - "codecov" paths: - "frontend/app_flowy/packages/appflowy_editor" @@ -20,7 +21,7 @@ jobs: tests: strategy: matrix: - os: [macos-latest, ubuntu-latest, windows-latest] + os: [ubuntu-latest] runs-on: ${{ matrix.os }} @@ -37,4 +38,7 @@ jobs: working-directory: frontend/app_flowy/packages/appflowy_editor run: | flutter pub get - flutter test + flutter test --coverage + curl -Os https://uploader.codecov.io/latest/linux/codecov + chmod +x codecov + ./codecov From 9d3fe302d59d0fd40f886edd58fd94c4e14a7bf8 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 15:56:15 +0800 Subject: [PATCH 3/9] chore: add codecov github action --- .github/workflows/flowy_editor_test.yml | 8 ++++++-- .../appflowy_editor/lib/src/document/position.dart | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 1459a475180c..4e14efa1a839 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -4,6 +4,7 @@ on: push: branches: - "main" + - "codecov" paths: - "frontend/app_flowy/packages/appflowy_editor" @@ -20,7 +21,7 @@ jobs: tests: strategy: matrix: - os: [macos-latest, ubuntu-latest, windows-latest] + os: [ubuntu-latest] runs-on: ${{ matrix.os }} @@ -37,4 +38,7 @@ jobs: working-directory: frontend/app_flowy/packages/appflowy_editor run: | flutter pub get - flutter test + flutter test --coverage + curl -Os https://uploader.codecov.io/latest/linux/codecov + chmod +x codecov + ./codecov diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart index cea065fdea1f..e8d684c599b6 100644 --- a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart +++ b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/position.dart @@ -14,6 +14,7 @@ class Position { if (other is! Position) { return false; } + return pathEquals(path, other.path) && offset == other.offset; } From 3914943a0ca2db17a668c56900ccaced8cf426fe Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:07:24 +0800 Subject: [PATCH 4/9] test --- .github/workflows/flowy_editor_test.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 4e14efa1a839..098e39aa72c0 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -5,14 +5,10 @@ on: branches: - "main" - "codecov" - paths: - - "frontend/app_flowy/packages/appflowy_editor" pull_request: branches: - "main" - paths: - - "frontend/app_flowy/packages/appflowy_editor" env: CARGO_TERM_COLOR: always From b440ca925322aae0d8ab9950978e2c6b98478d8b Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:13:07 +0800 Subject: [PATCH 5/9] test --- .github/workflows/flowy_editor_test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 098e39aa72c0..57fd34aa0dc3 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -13,6 +13,7 @@ on: env: CARGO_TERM_COLOR: always + jobs: tests: strategy: From f908fbb0fbff3e1fa79d5664abb8c1b8ce44e7ab Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:13:52 +0800 Subject: [PATCH 6/9] test --- .github/workflows/flowy_editor_test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 4e14efa1a839..520f64b09b89 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -39,6 +39,7 @@ jobs: run: | flutter pub get flutter test --coverage + curl -Os https://uploader.codecov.io/latest/linux/codecov chmod +x codecov ./codecov From f3dd5abaab31e37380aa2522f1c9998627dbb767 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:17:43 +0800 Subject: [PATCH 7/9] test --- frontend/app_flowy/packages/appflowy_editor/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frontend/app_flowy/packages/appflowy_editor/README.md b/frontend/app_flowy/packages/appflowy_editor/README.md index 1ccbf558787f..33d94d8e7336 100644 --- a/frontend/app_flowy/packages/appflowy_editor/README.md +++ b/frontend/app_flowy/packages/appflowy_editor/README.md @@ -18,6 +18,9 @@ and the Flutter guide for

Discord • Twitter + + +

From 2f89da86de7c6a7bbaecf02c2fa06e27d34aa200 Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:20:37 +0800 Subject: [PATCH 8/9] test --- frontend/app_flowy/packages/appflowy_editor/README.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/app_flowy/packages/appflowy_editor/README.md b/frontend/app_flowy/packages/appflowy_editor/README.md index 33d94d8e7336..9236d6cb4011 100644 --- a/frontend/app_flowy/packages/appflowy_editor/README.md +++ b/frontend/app_flowy/packages/appflowy_editor/README.md @@ -17,7 +17,11 @@ and the Flutter guide for

Discord • - Twitter + Twitter + +

+ +

From 96c432afe1477342d7738ac302e1a3d00940cb1f Mon Sep 17 00:00:00 2001 From: "Lucas.Xu" Date: Fri, 2 Sep 2022 16:24:42 +0800 Subject: [PATCH 9/9] test --- .github/workflows/flowy_editor_test.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/flowy_editor_test.yml b/.github/workflows/flowy_editor_test.yml index 8809bad3280d..2ecbecd7e1b1 100644 --- a/.github/workflows/flowy_editor_test.yml +++ b/.github/workflows/flowy_editor_test.yml @@ -37,6 +37,9 @@ jobs: flutter pub get flutter test --coverage - curl -Os https://uploader.codecov.io/latest/linux/codecov - chmod +x codecov - ./codecov + - uses: codecov/codecov-action@v3 + with: + name: appflowy_editor + fail_ci_if_error: true + verbose: true +