Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish process #860

Closed
4 of 5 tasks
sumneko opened this issue Dec 14, 2021 · 11 comments
Closed
4 of 5 tasks

Publish process #860

sumneko opened this issue Dec 14, 2021 · 11 comments
Assignees

Comments

@sumneko
Copy link
Collaborator

sumneko commented Dec 14, 2021

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 14, 2021

@numToStr Could you please help me to implement Remove <platform> folder and All in One ?

@numToStr
Copy link
Contributor

@numToStr Could you please help me to implement Remove <platform> folder and All in One ?

Sure. I'll update the workflow to build an all-in-one package until we'll be able release platform-specific vsix.

Meanwhile you can remove the platform folder as it won't effect the current workflow.

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 14, 2021

We do not need All in One, I could just publish according to the platform, it is not difficault.

@numToStr
Copy link
Contributor

Indeed, that'll be great. We could also setup action to publish platform-specific vsix. It'll cover all the points you've mentioned in the op.

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 14, 2021

Oh no, I forgot open-vsx.org , it seems not supports platform-specific vsix .

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 14, 2021

See eclipse/openvsx#336 .
We still need the All in One, or we just not release to the market until it supports platform-specific vsix.

@numToStr
Copy link
Contributor

We still need the All in One, or we just not release to the market until it supports platform-specific vsix.

An all-in-one asset is still possible even If you've removed the platform folder. As the workflow already has linux, darwin, and windows marker.

We can remove the all-in-one asset once open-vsx starts supporting platform-specific extensions.

@numToStr
Copy link
Contributor

@sumneko is linux-64 build for arm64 or x86_64?

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 16, 2021

I request off-site support @actboy168

@actboy168
Copy link
Collaborator

@numToStr linux-x64 means x86_64.

@sumneko
Copy link
Collaborator Author

sumneko commented Dec 17, 2021

Done

@sumneko sumneko closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants